Currently Elements panel is being shown on open, no matter which one user was using before.
Created attachment 32715 [details] patch
Comment on attachment 32715 [details] patch > + if (lastActivePanelSetting.type() == Setting::StringType) { > + m_showAfterVisible = specialPanelForJSName(lastActivePanelSetting.string()); > + } No need for the curly braces.
Sending WebCore/ChangeLog Sending WebCore/inspector/InspectorController.cpp Sending WebCore/inspector/InspectorController.h Sending WebCore/inspector/InspectorController.idl Sending WebCore/inspector/front-end/inspector.js Transmitting file data ..... Committed revision 45861.
After this was applied I got a small error when I open the Inspector with the ⌥⌘C shortcut that opens the console. TypeError: Result of expression 'WebInspector.currentPanel' [undefined] is not a valid argument for 'in'. That comes from Console.js, at approx line 87: http://trac.webkit.org/browser/trunk/WebCore/inspector/front-end/Console.js#L59 function animationFinished() { if ("updateStatusBarItems" in WebInspector.currentPanel) WebInspector.currentPanel.updateStatusBarItems(); WebInspector.currentFocusElement = this.promptElement; delete this._animating; } I think that has to do with the fact that a "this.currentPanel" was deleted in this patch.
Eek, opening with ⌥⌘I I am getting an empty error messages from: InspectorController.storeLastActivePanel(panelName);
Created attachment 32766 [details] patch
Created attachment 32767 [details] patch
Created attachment 32768 [details] patch
Sending WebCore/ChangeLog Sending WebCore/inspector/InspectorController.cpp Sending WebCore/inspector/InspectorController.idl Transmitting file data ... Committed revision 45899.
This error seems to happen because [WebInspector showConsole] firing before m_frontend is set causes m_showAfterVisible to be overridden from CurrentPanel to ConsolePanel. I'm not sure but maybe adding m_showConsoleAfterVisible would be a fix?
Created attachment 32847 [details] patch Special case ConsolePanel opening.
Comment on attachment 32847 [details] patch If this is closed as fixed, nothing should be marked for review.