Bug 272598 - [WebGPU] Generated dynamic offsets are incorrect in generated metal source
Summary: [WebGPU] Generated dynamic offsets are incorrect in generated metal source
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Wyrzykowski
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-04-12 11:36 PDT by Mike Wyrzykowski
Modified: 2024-04-12 14:57 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Wyrzykowski 2024-04-12 11:36:24 PDT
Open https://playcanvas.github.io/#/misc/spineboy

Observe the generated metal source:

    const constant __type0_Packed& global1 = (*(const constant __type0_Packed*)(((constant uint8_t*)&(__ArgumentBuffer_0.global1)) + __DynamicOffsets[0u]));
    const constant __type1_Packed& global5 = (*(const constant __type1_Packed*)(((constant uint8_t*)&(__ArgumentBuffer_1.global5)) + __DynamicOffsets[0u]));

both argument buffers are using the same offset (0), which is wrong, the first should be offset 0 and the second should be offset 1
Comment 1 Radar WebKit Bug Importer 2024-04-12 11:36:52 PDT
<rdar://problem/126365605>
Comment 2 EWS 2024-04-12 14:57:19 PDT
Committed 277439@main (02e0f7667792): <https://commits.webkit.org/277439@main>

Reviewed commits have been landed. Closing PR #27202 and removing active labels.