Bug 272538 - AX: Add AXCoreObject::isListBoxOption() implementation.
Summary: AX: Add AXCoreObject::isListBoxOption() implementation.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-04-11 11:24 PDT by Andres Gonzalez
Modified: 2024-04-11 17:10 PDT (History)
11 users (show)

See Also:

Attachments
Patch (8.08 KB, patch)
2024-04-11 11:32 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (7.99 KB, patch)
2024-04-11 11:38 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (7.99 KB, patch)
2024-04-11 11:48 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (7.87 KB, patch)
2024-04-11 14:11 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2024-04-11 11:24:15 PDT 
.
Comment 1 Radar WebKit Bug Importer 2024-04-11 11:24:24 PDT 
<rdar://problem/126287476>
Comment 2 Andres Gonzalez 2024-04-11 11:32:49 PDT 
Created attachment 470868 [details]
Patch
Comment 3 Joshua Hoffman 2024-04-11 11:37:04 PDT 
Comment on attachment 470868 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=470868&action=review

> Source/WebCore/accessibility/AccessibilityListBox.cpp:85
> +//        auto* listBoxOption = dynamicDowncast<AccessibilityListBoxOption>(child.get());

We should remove this commented code.
Comment 4 Andres Gonzalez 2024-04-11 11:38:05 PDT 
Created attachment 470869 [details]
Patch
Comment 5 Andres Gonzalez 2024-04-11 11:48:05 PDT 
Created attachment 470870 [details]
Patch
Comment 6 Andres Gonzalez 2024-04-11 14:11:50 PDT 
Created attachment 470871 [details]
Patch
Comment 7 EWS 2024-04-11 17:10:57 PDT 
Committed 277404@main (a66b929d15c4): <https://commits.webkit.org/277404@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 470871 [details].