WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
272529
[results.webkit.org] Fetch missing range commit on dashboard
https://bugs.webkit.org/show_bug.cgi?id=272529
Summary
[results.webkit.org] Fetch missing range commit on dashboard
Jonathan Bedard
Reported
2024-04-11 08:17:18 PDT
Users can specify a "before_ref" argument to display a previous version of the dashboard. In
277252@main
, we added this ability. It turns out, though, that the dashboard won't display correctly unless the provided ref can be converted to a timestamp, which can only happen if the provided ref is within the CommitBank. That's often the case (because we define the CommitBank based on the builds we found), but it's possible for the ref to be just outside the range of known commits. If we could explicitly add a commit to the CommitBank, we can fix this edge case.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-04-11 08:17:29 PDT
<
rdar://problem/126275308
>
Jonathan Bedard
Comment 2
2024-04-11 08:27:49 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/27144
EWS
Comment 3
2024-04-30 20:19:25 PDT
Committed
278202@main
(a71b5c17fafc): <
https://commits.webkit.org/278202@main
> Reviewed commits have been landed. Closing PR #27144 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug