Bug 27250 – Geolocation callback function IDL files are superfluous

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Steve Block]

The IDL files for the callback functions used in Geolocation (WebCore/page/PositionCallback.idl and WebCore/page/PositionErrorCallback.idl) appear to be superfluous.

The objects for these callbacks are created 'manually' in WebCore/bindings/js/JSGeolocationCustom.cpp. It looks like the IDL files can be removed.

[Steve Block]

Created attachment 33433 [details]
Patch for bug 27250

[Oliver Hunt]

Sam should look at this patch, i'm not convinced that these should be removed -- that they are *currently* created manually does not necessarily imply that the idl shouldn't exist.

[David Levin]

Added Sam to cc per Oliver's comment.

[Eric Seidel (no email)]

Comment on attachment 33433 [details]
Patch for bug 27250

Because we implement them via custom files?   GenerateConstructor is going to change what's exposed on the window object, no?

[Steve Block]

> Because we implement them via custom files?
Yes

> GenerateConstructor is going to change what's exposed on the window object, no?
I see, so GenerateConstructor provides a type and prototype for PositionCallback - http://lists.w3.org/Archives/Public/www-archive/2007May/0068.html

But it looks like these shouldn't be present for the callbacks. See
http://www.w3.org/TR/geolocation-API/#geolocation_interface and http://www.w3.org/TR/WebIDL/#NoInterfaceObject.

[Eric Seidel (no email)]

Comment on attachment 33433 [details]
Patch for bug 27250

Please add those comments above to the ChangeLog, with spec references.

[Steve Block]

Created attachment 34267 [details]
Patch for bug 27250

Updated ChangeLog as requested.

[Adam Barth]

Comment on attachment 34267 [details]
Patch for bug 27250

Clearing review flag on attachment: 34267

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	D	WebCore/page/PositionCallback.idl
	D	WebCore/page/PositionErrorCallback.idl
	M	WebCore/ChangeLog
	M	WebCore/DerivedSources.make
	M	WebCore/WebCore.gypi
	M	WebCore/WebCore.xcodeproj/project.pbxproj
Committed r46906
	M	WebKitTools/DumpRenderTree/qt/DumpRenderTree.cpp
	M	WebKitTools/ChangeLog
r46905 = de57f68b5591e881375ef49ffc6005fdca83d648 (trunk)
	M	WebCore/ChangeLog
	D	WebCore/page/PositionErrorCallback.idl
	D	WebCore/page/PositionCallback.idl
	M	WebCore/WebCore.gypi
	M	WebCore/DerivedSources.make
	M	WebCore/WebCore.xcodeproj/project.pbxproj
r46906 = 1a765091c3a1e8fe37ec08c9084c5db5a372e6c9 (trunk)
First, rewinding head to replay your work on top of it...
Nothing to do.
http://trac.webkit.org/changeset/46906

[Adam Barth]

All reviewed patches have been landed.  Closing bug.