Bug 27241 – bugzilla-tool post-commits silently fails with bad args

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Eric Seidel (no email)]

bugzilla-tool post-commits silently fails with bad args

I tried:

bugzilla-tool post-commits --no-review 27088 head

Which used to be the syntax.  That just exited 0, and gave no indication of failure. :(

[Eric Seidel (no email)]

Sigh.  Also:

bugzilla-tool post-commits --no-review -b 27088 trunk

Doesn't work as I expected it to.  git-send-bugzilla used to make that into trunk...HEAD.  Now it just posted "trunk".  I guess it's just assuming a --cherry-pick arg.  Maybe the new way is more intuitive?  donno.

[Eric Seidel (no email)]

The new behavior will certainly confuse git-send-bugzilla users. :)  But maybe that's OK.

[David Kilzer (:ddkilzer)]

(In reply to comment #2)
> The new behavior will certainly confuse git-send-bugzilla users. :)  But maybe
> that's OK.

Sorry, I've never used git-send-bugzilla.  I explained the reason for this change in Bug 27062 Comment #3 and Bug 27062 Comment #5.

I'll look at the --no-review issue tomorrow.

[David Kilzer (:ddkilzer)]

Created attachment 32833 [details]
Patch v1

[Eric Seidel (no email)]

Comment on attachment 32833 [details]
Patch v1

You could probably re-use the self.argnames string (or wahtever it's called).  Instead of re-typing "COMMITTISH".  

I probably woudl have written "'%s' is not a COMMITISH" as "unable to parse commit is from %s".

What you have is fine.  Or with one or more of the modifications suggested above.

Thanks!

[David Kilzer (:ddkilzer)]

$ git svn dcommit
Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       WebKitTools/ChangeLog
        M       WebKitTools/Scripts/bugzilla-tool
Committed r45978

http://trac.webkit.org/changeset/45978