RESOLVED FIXED 27241
bugzilla-tool post-commits silently fails with bad args
https://bugs.webkit.org/show_bug.cgi?id=27241
Summary bugzilla-tool post-commits silently fails with bad args
Eric Seidel (no email)
Reported 2009-07-13 17:46:42 PDT
bugzilla-tool post-commits silently fails with bad args I tried: bugzilla-tool post-commits --no-review 27088 head Which used to be the syntax. That just exited 0, and gave no indication of failure. :(
Attachments
Patch v1 (1.63 KB, patch)
2009-07-15 21:50 PDT, David Kilzer (:ddkilzer)
eric: review+
Eric Seidel (no email)
Comment 1 2009-07-13 17:47:49 PDT
Sigh. Also: bugzilla-tool post-commits --no-review -b 27088 trunk Doesn't work as I expected it to. git-send-bugzilla used to make that into trunk...HEAD. Now it just posted "trunk". I guess it's just assuming a --cherry-pick arg. Maybe the new way is more intuitive? donno.
Eric Seidel (no email)
Comment 2 2009-07-13 17:48:12 PDT
The new behavior will certainly confuse git-send-bugzilla users. :) But maybe that's OK.
David Kilzer (:ddkilzer)
Comment 3 2009-07-13 21:00:42 PDT
(In reply to comment #2) > The new behavior will certainly confuse git-send-bugzilla users. :) But maybe > that's OK. Sorry, I've never used git-send-bugzilla. I explained the reason for this change in Bug 27062 Comment #3 and Bug 27062 Comment #5. I'll look at the --no-review issue tomorrow.
David Kilzer (:ddkilzer)
Comment 4 2009-07-15 21:50:56 PDT
Created attachment 32833 [details] Patch v1
Eric Seidel (no email)
Comment 5 2009-07-15 21:59:29 PDT
Comment on attachment 32833 [details] Patch v1 You could probably re-use the self.argnames string (or wahtever it's called). Instead of re-typing "COMMITTISH". I probably woudl have written "'%s' is not a COMMITISH" as "unable to parse commit is from %s". What you have is fine. Or with one or more of the modifications suggested above. Thanks!
David Kilzer (:ddkilzer)
Comment 6 2009-07-16 10:26:46 PDT
$ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool Committed r45978 http://trac.webkit.org/changeset/45978
Note You need to log in before you can comment on or make changes to this bug.