RESOLVED FIXED 272380
[WPE] REGRESSION(277190@main): build broken when using NEON filters 
https://bugs.webkit.org/show_bug.cgi?id=272380
Summary [WPE] REGRESSION(277190@main): build broken when using NEON filters
Miguel Gomez
Reported 2024-04-09 02:18:36 PDT
277190@main changed the API to access a PixelBuffer's bytes in this way: - uint8_t* bytes() const { return m_bytes; } - size_t sizeInBytes() const { return m_sizeInBytes; } + std::span<uint8_t> bytes() const { return m_bytes; } The NEON filters weren't updated with this change, so the build is broken when trying to use them.
Attachments
Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2024-04-09 09:16:11 PDT
Not surprising. Code not built by EWS so it will break!
Darin Adler
Comment 2 2024-04-10 07:28:01 PDT
Happy to review a patch to fix this.
Przemyslaw Gorszkowski
Comment 3 2024-04-10 09:25:24 PDT
Pull request: https://github.com/WebKit/WebKit/pull/27089
EWS
Comment 4 2024-04-11 00:33:25 PDT
Committed 277365@main (edc1bf6b0c8a): <https://commits.webkit.org/277365@main> Reviewed commits have been landed. Closing PR #27089 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.