RESOLVED FIXED 272319
[build.webkit.org] Forcing a build with a hash fails for WebKitGTK and WPE builders 
https://bugs.webkit.org/show_bug.cgi?id=272319
Summary [build.webkit.org] Forcing a build with a hash fails for WebKitGTK and WPE bu...
Diego Pino
Reported 2024-04-08 04:02:49 PDT
Forcing a build with a hash fails for WebKitGTK and WPE builders. For instance: https://build.webkit.org/#/builders/859/builds/7807 The build fails in the 'upload-file-to-s3' because the file 'minified-release.zip' doesn't exist. The previous step in the build, 'archive-minified-built-product', executes the following command: ``` Tools/CISupport/built-product-archive --platform=wpe --release --minify archive ``` The command above produces 'WebKitBuild/release.zip', because minified archives are only supported in platforms Mac, iOS, tvOS and WatchOS (https://github.com/WebKit/WebKit/blob/main/Tools/CISupport/built-product-archive#L250). It seems the issue is in this line: https://github.com/WebKit/WebKit/blob/main/Tools/CISupport/build-webkit-org/steps.py#L483. I think the creation of minified built products, and its consequent upload, should only happen if the current platform supports minified archives.
Attachments
Add attachment proposed patch, testcase, etc.
Diego Pino
Comment 1 2024-04-08 04:06:21 PDT
Pull request: https://github.com/webkit/webkit/pull/26967
EWS
Comment 2 2024-04-09 01:20:51 PDT
Committed 277235@main (e449d0612995): <https://commits.webkit.org/277235@main> Reviewed commits have been landed. Closing PR #26967 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2024-04-09 01:21:16 PDT
<rdar://problem/126122339>
Note You need to log in before you can comment on or make changes to this bug.