Bug 27231 - REGRESSION: Clicking on nodes in the console should take you to the element in the DOM
Summary: REGRESSION: Clicking on nodes in the console should take you to the element i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: https://bugs.webkit.org/show_bug.cgi?...
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2009-07-13 12:27 PDT by Alexander Kellett
Modified: 2009-10-21 12:36 PDT (History)
4 users (show)

See Also:


Attachments
proposed patch (4.19 KB, patch)
2009-10-21 11:17 PDT, Keishi Hattori
timothy: review-
Details | Formatted Diff | Diff
proposed patch 2 (2.60 KB, patch)
2009-10-21 11:36 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kellett 2009-07-13 12:27:47 PDT
Clicking on any of the child nodes should take you to the DOM view and select
the clicked child.
Comment 1 Adam Roben (:aroben) 2009-07-13 12:32:01 PDT
This used to work. I think it broke in r41404: <http://trac.webkit.org/changeset/41404>.
Comment 2 Keishi Hattori 2009-10-21 11:17:16 PDT
Created attachment 41584 [details]
proposed patch

Clicking on a node in the console will select the node in the Elements panel.
Comment 3 Timothy Hatcher 2009-10-21 11:22:52 PDT
Comment on attachment 41584 [details]
proposed patch


> +        if (this.showInElementsPanel)

This can just be:

           if (this.treeOutline.showInElementsPanelEnabled)

Then you don't need all the propagation code.

> +            WebInspector.panels.elements.focusedDOMNode = this.representedObject;

We should switch to the Elements panel if it isn't visible too.
Comment 4 Keishi Hattori 2009-10-21 11:36:38 PDT
Created attachment 41591 [details]
proposed patch 2

I fixed the issues.
Comment 5 WebKit Commit Bot 2009-10-21 12:36:18 PDT
Comment on attachment 41591 [details]
proposed patch 2

Clearing flags on attachment: 41591

Committed r49917: <http://trac.webkit.org/changeset/49917>
Comment 6 WebKit Commit Bot 2009-10-21 12:36:21 PDT
All reviewed patches have been landed.  Closing bug.