Bug 27205 - [Qt] Buildfix for QtWebKit on Win
Summary: [Qt] Buildfix for QtWebKit on Win
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-12 23:00 PDT by Laszlo Gombos
Modified: 2009-07-13 07:55 PDT (History)
1 user (show)

See Also:

Attachments
Proposed patch. (1.09 KB, patch)
2009-07-12 23:41 PDT, Laszlo Gombos 		vestbo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-07-12 23:00:47 PDT 
On Windows the target binary filename includes the major QtWebKit version number (e.g. QtWebKit4.lib, libQtWebKit4.a, QtWebKit4.dll).
The version number needs to be included in the filename when linking against QtWebkit on win (e.g. when building QtLauncher) otherwise the linker will not find the library.
Comment 1 Laszlo Gombos 2009-07-12 23:41:57 PDT 
Created attachment 32647 [details]
Proposed patch.

Tested on win32-msvc2005.
Comment 2 Tor Arne Vestbø 2009-07-13 07:47:59 PDT 
Comment on attachment 32647 [details]
Proposed patch.

Looks good, thanks!
Comment 3 Tor Arne Vestbø 2009-07-13 07:55:08 PDT 
Landed in r45821 = 1c014fef133212af762efdf187b54bfe1be4dcf2 (svn/trunk)