Bug 272033 - Fix build after drop of String constructor with raw pointer and length
Summary: Fix build after drop of String constructor with raw pointer and length
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 271974 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-04-02 09:04 PDT by Olivier Blin
Modified: 2024-04-03 07:48 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Blin 2024-04-02 09:04:20 PDT 
String constructors taking in a raw pointer and a length have been dropped in 276859@main

One codepath without HAVE(ICU_U_NUMBER_FORMATTER) has not been migrated in IntlPluralRules.cpp, and one ASSERT() has not been removed in SVGTextMetrics.cpp.
Comment 1 Olivier Blin 2024-04-02 09:08:55 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/26727
Comment 2 EWS 2024-04-02 10:44:09 PDT 
merge-queue failed to commit PR to repository. To retry, remove any blocking labels and re-apply merge-queue label
Comment 3 EWS 2024-04-02 12:03:16 PDT 
Committed 276954@main (34d037641b00): <https://commits.webkit.org/276954@main>

Reviewed commits have been landed. Closing PR #26727 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2024-04-02 12:04:14 PDT 
<rdar://problem/125796536>
Comment 5 Alex 2024-04-03 07:48:32 PDT 
*** Bug 271974 has been marked as a duplicate of this bug. ***