Bug 272010 - Allow using add_subdirectory with WebKit and/or JSC
Summary: Allow using add_subdirectory with WebKit and/or JSC
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-04-01 18:12 PDT by Theo Paris
Modified: 2024-04-11 10:33 PDT (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Theo Paris 2024-04-01 18:12:39 PDT 
I would like to make a PR that allows webkit's cmake build files to be added in another project using `add_subdirectory(WebKit).
This would make it easier to embed the entire webkit project as well as JSC individually.

See https://github.com/BunOSLabs/WebKit/commit/9b1c39fdee8a904460e73dbb5471c86caaef78f4 for the current changes I have come up with. So far I have changed CMAKE_{SOURCE,BINARY}_DIR to CMAKE_CURRENT_{SOURCE,BINARY}_DIR. Not sure if there's anything else that would be needed yet.
Comment 1 Theo Paris 2024-04-01 18:14:20 PDT 
Maybe adding a install target for JSC would be good as well.
Comment 2 Radar WebKit Bug Importer 2024-04-08 18:13:14 PDT 
<rdar://problem/126106710>
Comment 3 Keith Miller 2024-04-09 05:33:04 PDT 
I'm not opposed to a PR that does this. That said, since Apple ports don't use CMake it should probably be someone from a CMake port that reviews your change.