NEW 272010
Allow using add_subdirectory with WebKit and/or JSC 
https://bugs.webkit.org/show_bug.cgi?id=272010
Summary Allow using add_subdirectory with WebKit and/or JSC
Theo Paris
Reported 2024-04-01 18:12:39 PDT
I would like to make a PR that allows webkit's cmake build files to be added in another project using `add_subdirectory(WebKit). This would make it easier to embed the entire webkit project as well as JSC individually. See https://github.com/BunOSLabs/WebKit/commit/9b1c39fdee8a904460e73dbb5471c86caaef78f4 for the current changes I have come up with. So far I have changed CMAKE_{SOURCE,BINARY}_DIR to CMAKE_CURRENT_{SOURCE,BINARY}_DIR. Not sure if there's anything else that would be needed yet.
Attachments
Add attachment proposed patch, testcase, etc.
Theo Paris
Comment 1 2024-04-01 18:14:20 PDT
Maybe adding a install target for JSC would be good as well.
Radar WebKit Bug Importer
Comment 2 2024-04-08 18:13:14 PDT
<rdar://problem/126106710>
Keith Miller
Comment 3 2024-04-09 05:33:04 PDT
I'm not opposed to a PR that does this. That said, since Apple ports don't use CMake it should probably be someone from a CMake port that reviews your change.
Note You need to log in before you can comment on or make changes to this bug.