Bug 272006 - Web Extension objects should return the same JS wrapper (Bitwarden popup never loads)
Summary: Web Extension objects should return the same JS wrapper (Bitwarden popup neve...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Extensions (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-04-01 17:28 PDT by Timothy Hatcher
Modified: 2024-04-02 08:23 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2024-04-01 17:28:18 PDT 
We currently make a new JSObjectRef each time, we should have a cache per global context that lets us return the same wrapper.

rdar://125633239
Comment 1 Timothy Hatcher 2024-04-01 17:34:03 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/26707
Comment 2 EWS 2024-04-02 08:23:47 PDT 
Committed 276935@main (fe7e1f64e14e): <https://commits.webkit.org/276935@main>

Reviewed commits have been landed. Closing PR #26707 and removing active labels.