WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
271997
Build failures in GeneratedSerializers.cpp in release builds with assertions enabled
https://bugs.webkit.org/show_bug.cgi?id=271997
Summary
Build failures in GeneratedSerializers.cpp in release builds with assertions ...
Michael Catanzaro
Reported
2024-04-01 14:33:39 PDT
Splitting this out from
bug #271337
. The condition for enabling assertions in ThreadSafeRefCounted.h (which checks NDEBUG) should match the comparable condition in RefCounted.h (which checks ASSERT_ENABLED). This will avoid tripping static assertions in GeneratedSerializers.cpp described in
bug #271337
, which was confusing a user who got a bit too inventive and tried enabling asserts in release builds.
Attachments
Add attachment
proposed patch, testcase, etc.
Michael Catanzaro
Comment 1
2024-04-01 14:41:36 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/26700
Radar WebKit Bug Importer
Comment 2
2024-04-08 14:34:14 PDT
<
rdar://problem/126095861
>
EWS
Comment 3
2024-04-09 08:54:42 PDT
Committed
277248@main
(2e1188405ef9): <
https://commits.webkit.org/277248@main
> Reviewed commits have been landed. Closing PR #26700 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug