Bug 271923 - [CSS-UI] Remove non-standard / invalid 'appearance' keywords
Summary: [CSS-UI] Remove non-standard / invalid 'appearance' keywords
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BrowserCompat, InRadar, WPTImpact
Depends on:
Blocks:
 
Reported: 2024-03-29 17:53 PDT by Ahmad Saleem
Modified: 2024-04-08 17:40 PDT (History)
4 users (show)

See Also:


Attachments
testcase (3.35 KB, text/html)
2024-04-08 17:40 PDT, Karl Dubost
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2024-03-29 17:53:30 PDT
Hi Team,

While looking into Firefox specific failures, I noticed that we are failing following sub-tests:

WPT Test Case: https://wpt.fyi/results/css/css-ui/appearance-cssom-001.html%3Finclude=Invalid?label=master&label=experimental&aligned=&q=safari%3Afail

> Push-Button
> Square-Button
> Slider Vertical
> Slider Horizontal
> Apple Pay (might want to keep)

__

It seems to be not in specification - https://drafts.csswg.org/css-ui-4/#appearance-switching

So I am raising this bug to get input and track if we can remove them or workaround them.

If I just remove them (except Apple Pay - again might want to keep) from CSSProperties.json, it compiles and progress all tests except two related to 'Apple Pay'.

@Tim - any insight?

Thanks!
Comment 1 Tim Nguyen (:ntim) 2024-03-29 17:59:46 PDT
I did a large clean up of the invalid ones a while back, but I think `-webkit-appearance: -apple-pay-button` is one we can't remove due to web compat. `-webkit-appearance: slider-vertical` is one we'd like to have a standard replacement for. 

Maybe Aditya can comment on the other ones.
Comment 2 Aditya Keerthi 2024-03-29 18:13:41 PDT
I'm in favor of removing push-button / square-button from Safari. However, I'm aware of at least one internal app that relies on square-button.

I think the goal would be to remove behind a link check at some point.
Comment 3 Aditya Keerthi 2024-03-29 18:14:53 PDT
I don't expect that there are any real compatibility issues here though, given the extremely rare usage (if any) on the web. Just an interop difference.
Comment 4 Radar WebKit Bug Importer 2024-04-05 17:54:12 PDT
<rdar://problem/126000107>
Comment 5 Karl Dubost 2024-04-08 17:40:11 PDT
Created attachment 470826 [details]
testcase

@Ahmad, 

This test case combines all input and appearance. 
This is basically non-sense but also helps determine if some of the values combinations have uncharacteristic behaviors.