RESOLVED FIXED Bug 27181
StorageArea should only contain methods we intend to proxy 
https://bugs.webkit.org/show_bug.cgi?id=27181
Summary StorageArea should only contain methods we intend to proxy
Jeremy Orlow
Reported 2009-07-11 13:30:12 PDT
Right now, StorageAreaSync takes in a StorageArea* and calls methods like impotItem. Really, StorageAreaSync should be operating directly on StorageAreaImpl* and those methods should be removed from StorageArea since StorageAreaSync should never be attached to anything other than a StorageAreaImpl. This was pointed out in the review for https://bugs.webkit.org/show_bug.cgi?id=27072 But depends on some other cleanup https://bugs.webkit.org/show_bug.cgi?id=27180
Attachments
v1 (17.72 KB, patch)
2009-07-15 21:17 PDT, Jeremy Orlow 		fishd: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2009-07-15 21:17:57 PDT
Created attachment 32828 [details] v1 StorageArea should only contain methods we intend to proxy. https://bugs.webkit.org/show_bug.cgi?id=27181 Right now, StorageAreaSync takes in a StorageArea* and calls methods like importItem. Really, StorageAreaSync should be operating directly on StorageAreaImpl* and those methods should be removed from StorageArea since StorageAreaSync should never be attached to anything other than a StorageAreaImpl. This was pointed out in the review for https://bugs.webkit.org/show_bug.cgi?id=27072 Also clean up StorageNamespaceImpl to operate directly on StorageAreaImpl. Also, get rid of the factory for StorageArea since nothing should ever create a StorageArea directly.
Jeremy Orlow
Comment 2 2009-07-17 18:43:11 PDT
Landed in r46075
Note You need to log in before you can comment on or make changes to this bug.