Right now, StorageAreaSync takes in a StorageArea* and calls methods like impotItem. Really, StorageAreaSync should be operating directly on StorageAreaImpl* and those methods should be removed from StorageArea since StorageAreaSync should never be attached to anything other than a StorageAreaImpl. This was pointed out in the review for https://bugs.webkit.org/show_bug.cgi?id=27072 But depends on some other cleanup https://bugs.webkit.org/show_bug.cgi?id=27180
Created attachment 32828 [details] v1 StorageArea should only contain methods we intend to proxy. https://bugs.webkit.org/show_bug.cgi?id=27181 Right now, StorageAreaSync takes in a StorageArea* and calls methods like importItem. Really, StorageAreaSync should be operating directly on StorageAreaImpl* and those methods should be removed from StorageArea since StorageAreaSync should never be attached to anything other than a StorageAreaImpl. This was pointed out in the review for https://bugs.webkit.org/show_bug.cgi?id=27072 Also clean up StorageNamespaceImpl to operate directly on StorageAreaImpl. Also, get rid of the factory for StorageArea since nothing should ever create a StorageArea directly.
Landed in r46075