RESOLVED FIXED 271729
Rename *widthFor* functions 
https://bugs.webkit.org/show_bug.cgi?id=271729
Summary Rename *widthFor* functions
Vitor Roriz
Reported 2024-03-26 14:31:51 PDT
We currently have: 1. widthForSimpleText 2. floatWidthForSimpleText 3. floatWidthForComplexText These functions all do something similar but their names are a bit confusing, specially by the different meanings of the word "simple" here. As previously described by @zallan with other words, the 3 function scale in level of complexity. 1. widthForSimpleText: does not use any width iterator, but has to pass "computeCanUseSimplifiedTextMeasuring" to be used. 2. floatWidthForSimpleText: It is used when we have a CodePath::Simple (calculated on FontCascade). It uses iterator WidthIterator 3. floatWidthForComplexText: It is used when we have a CodePath::Complex (calculated on FontCascade). It uses the ComplexTextControler, a more complete and slower iterator (supports kerning and ligaments, for example, which are currently not supported by WidthIterator). We could probably have more explicit names for avoiding the confusion.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-03-26 14:32:14 PDT
<rdar://problem/125440731>
Vitor Roriz
Comment 2 2024-03-26 14:43:07 PDT
Pull request: https://github.com/WebKit/WebKit/pull/26483
EWS
Comment 3 2024-03-26 17:01:00 PDT
Committed 276716@main (31aadb040e32): <https://commits.webkit.org/276716@main> Reviewed commits have been landed. Closing PR #26483 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.