RESOLVED FIXED271696
[LibWebRTC][Linux] Make PulseAudio support optional 
https://bugs.webkit.org/show_bug.cgi?id=271696
Summary [LibWebRTC][Linux] Make PulseAudio support optional
Philippe Normand
Reported 2024-03-26 01:31:16 PDT
ssia
Attachments
Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2024-03-26 01:35:19 PDT
Pull request: https://github.com/WebKit/WebKit/pull/26455
EWS
Comment 2 2024-03-26 13:10:34 PDT
Committed 276708@main (b5a59471fd29): <https://commits.webkit.org/276708@main> Reviewed commits have been landed. Closing PR #26455 and removing active labels.
Diego Pino
Comment 3 2024-03-26 23:12:55 PDT
After this change the GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004 bot was failing with the following build error: ``` CMake Error at Source/ThirdParty/libwebrtc/CMakeLists.txt:2172 (target_include_directories): Cannot specify include directories for target "webrtc" which is not built by this project. CMake Error at Source/ThirdParty/libwebrtc/CMakeLists.txt:2173 (target_compile_options): Cannot specify compile options for target "webrtc" which is not built by this project. ``` 'webrtc' is not defined yet at those lines, so they should be moved below in the file.
Diego Pino
Comment 4 2024-03-26 23:13:30 PDT
Re-opening for pull request https://github.com/webkit/webkit/pull/26500
EWS
Comment 5 2024-03-26 23:45:43 PDT
Committed 276724@main (b81583054864): <https://commits.webkit.org/276724@main> Reviewed commits have been landed. Closing PR #26500 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.