Bug 271696 - [LibWebRTC][Linux] Make PulseAudio support optional
Summary: [LibWebRTC][Linux] Make PulseAudio support optional
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-26 01:31 PDT by Philippe Normand
Modified: 2024-03-26 23:45 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2024-03-26 01:31:16 PDT 
ssia
Comment 1 Philippe Normand 2024-03-26 01:35:19 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/26455
Comment 2 EWS 2024-03-26 13:10:34 PDT 
Committed 276708@main (b5a59471fd29): <https://commits.webkit.org/276708@main>

Reviewed commits have been landed. Closing PR #26455 and removing active labels.
Comment 3 Diego Pino 2024-03-26 23:12:55 PDT 
After this change the GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004 bot was failing with the following build error:

```
CMake Error at Source/ThirdParty/libwebrtc/CMakeLists.txt:2172 (target_include_directories):
  Cannot specify include directories for target "webrtc" which is not built
  by this project.
CMake Error at Source/ThirdParty/libwebrtc/CMakeLists.txt:2173 (target_compile_options):
  Cannot specify compile options for target "webrtc" which is not built by
  this project.
```

'webrtc' is not defined yet at those lines, so they should be moved below in the file.
Comment 4 Diego Pino 2024-03-26 23:13:30 PDT 
Re-opening for pull request https://github.com/webkit/webkit/pull/26500
Comment 5 EWS 2024-03-26 23:45:43 PDT 
Committed 276724@main (b81583054864): <https://commits.webkit.org/276724@main>

Reviewed commits have been landed. Closing PR #26500 and removing active labels.