Bug 27155 - bug in V8Custom invokeCallback which will crash on void callbacks
Summary: bug in V8Custom invokeCallback which will crash on void callbacks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-10 13:21 PDT by John Gregg
Modified: 2009-07-13 02:34 PDT (History)
1 user (show)

See Also:


Attachments
Fix the logic for computing the return value (1.25 KB, patch)
2009-07-10 16:05 PDT, John Gregg
levin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Gregg 2009-07-10 13:21:02 PDT
There's an incorrect check for an empty result in V8CustomVoidCallback.cpp.
Comment 1 John Gregg 2009-07-10 16:05:33 PDT
Created attachment 32589 [details]
Fix the logic for computing the return value

One-character fix to the logic for computing the return value.
Comment 2 David Levin 2009-07-13 02:14:27 PDT
Note for the future:  Please avoid TABs (in the changelog).
Comment 3 David Levin 2009-07-13 02:34:27 PDT
Committed as http://trac.webkit.org/changeset/45796