RESOLVED FIXED 27153
Add delegate methods about focus and blur and state change
https://bugs.webkit.org/show_bug.cgi?id=27153
Summary Add delegate methods about focus and blur and state change
Greg Bolsinga
Reported Friday, July 10, 2009 7:33:21 PM UTC
Some platforms need to be informed when focus and blur events occur. They may display chrome UI when these events occur.
Attachments
This patch implements the needed changes (7.65 KB, patch)
2009-07-10 12:04 PDT, Greg Bolsinga
no flags
Remove the FrameView diff; it wasn't supposed to be there. (7.08 KB, patch)
2009-07-10 12:08 PDT, Greg Bolsinga
koivisto: review+
fixes up delegate method names (3.20 KB, patch)
2009-08-10 13:12 PDT, Greg Bolsinga
eric: review+
Greg Bolsinga
Comment 1 Friday, July 10, 2009 8:04:19 PM UTC
Created attachment 32569 [details] This patch implements the needed changes
Greg Bolsinga
Comment 2 Friday, July 10, 2009 8:08:39 PM UTC
Created attachment 32570 [details] Remove the FrameView diff; it wasn't supposed to be there.
Antti Koivisto
Comment 3 Friday, July 10, 2009 9:12:17 PM UTC
Comment on attachment 32570 [details] Remove the FrameView diff; it wasn't supposed to be there. r=me
Greg Bolsinga
Comment 4 Friday, July 10, 2009 9:32:58 PM UTC
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/html/HTMLFormControlElement.cpp M WebCore/html/HTMLFormControlElement.h M WebCore/loader/EmptyClients.h M WebCore/page/ChromeClient.h M WebKit/mac/ChangeLog M WebKit/mac/WebCoreSupport/WebChromeClient.h M WebKit/mac/WebCoreSupport/WebChromeClient.mm M WebKit/mac/WebView/WebUIDelegatePrivate.h Committed r45723
Adele Peterson
Comment 5 Friday, July 10, 2009 9:36:39 PM UTC
The naming is a little weird. formDidFocus gets called when a form control was focused...and formDidFocus doesn't actually give any info about a particular form.
David Kilzer (:ddkilzer)
Comment 6 Friday, July 10, 2009 11:18:58 PM UTC
Greg Bolsinga
Comment 7 Saturday, July 11, 2009 1:19:21 AM UTC
I named it this way following the style of: virtual void formStateDidChange(const Node*) What do you suggest?
Greg Bolsinga
Comment 8 Monday, August 10, 2009 9:05:15 PM UTC
I see what you mean now. I'll attach a patch to clean up these delegate method names.
Greg Bolsinga
Comment 9 Monday, August 10, 2009 9:12:41 PM UTC
Created attachment 34503 [details] fixes up delegate method names This is a new patch.
Eric Seidel (no email)
Comment 10 Wednesday, August 12, 2009 6:44:01 AM UTC
Comment on attachment 34503 [details] fixes up delegate method names Looks fine.
Greg Bolsinga
Comment 11 Wednesday, August 12, 2009 5:56:13 PM UTC
Thanks! Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/mac/ChangeLog M WebKit/mac/WebCoreSupport/WebChromeClient.mm M WebKit/mac/WebView/WebUIDelegatePrivate.h Committed r47119
Note You need to log in before you can comment on or make changes to this bug.