Bug 271449 – Invalidate SVG filter results in SVGResourcesCache::clientLayoutChanged()

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Ahmad Saleem]

Hi Team,

While looking into Blink commits, I noticed that we fail following test:

Test Case: https://jsfiddle.net/LqaFY/show

^ Safari Technology Preview 190 and Minibrowser does not show any text in container while Chrome Canary 125 does.

Blink Commit: https://chromium.googlesource.com/chromium/blink/+/25d72ebd50bec9a4caa426e735e5ee7292c4da69

WebKit Source: https://searchfox.org/wubkat/rev/1ad9a7beb555644c0b5f949b8f635e305018ab4a/Source/WebCore/rendering/svg/SVGResourcesCache.cpp#122

I change following:

if (renderer.selfNeedsLayout() && hasResourcesRequiringRemovalOnClientLayoutChange(*resources))

to

if ((renderer.selfNeedsLayout() || resources->filter()) && hasResourcesRequiringRemovalOnClientLayoutChange(*resources))

__

then we start passing above test, although we don't have this bug in Layer-based SVG engine.

I am not sure how much it be worth to fix it in legacy and we already passing test case mentioned in the bug.

Just raising to track it down.

Thanks!

[EWS]

Committed 276808@main (34cb73b0f69d): <https://commits.webkit.org/276808@main>

Reviewed commits have been landed. Closing PR #26537 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/125583987>