WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
271442
[iOS] fast/events/ios/rotation/basic-rotation.html is constantly failing.
https://bugs.webkit.org/show_bug.cgi?id=271442
Summary
[iOS] fast/events/ios/rotation/basic-rotation.html is constantly failing.
Ben Schwartz
Reported
2024-03-21 20:27:25 PDT
fast/events/ios/rotation/basic-rotation.html This test is constantly failing on iOS. TEXT DIFF: Before rotation -PASS window.innerWidth is 320 -PASS window.innerHeight is 548 +FAIL window.innerWidth should be 320. Was 390. +FAIL window.innerHeight should be 548. Was 797. +In resize event handler: +FAIL window.innerWidth should be 568. Was 600. +FAIL window.innerHeight should be 320. Was 390. + In orientationchange event handler: -FAIL window.innerWidth should be 568. Was 320. -FAIL window.innerHeight should be 320. Was 548. - -In resize event handler: -PASS window.innerWidth is 568 -PASS window.innerHeight is 320 +FAIL window.innerWidth should be 568. Was 844. +FAIL window.innerHeight should be 320. Was 390. After rotation -PASS window.innerWidth is 568 -PASS window.innerHeight is 320 +FAIL window.innerWidth should be 568. Was 844. +FAIL window.innerHeight should be 320. Was 390. Rotation test. DIFF URL:
https://build.webkit.org/results/Apple-iOS-17-Simulator-Release-WK2-Tests/276509@main%20(2575)/fast/events/ios/rotation/basic-rotation-pretty-diff.html
REPRODUCIBILITY: I was able to reproduce this issue on the iOS Simulator (17.4/21E213) ToT using the following command: run-webkit-tests -v fast/events/ios/rotation/basic-rotation.html REGRESSION: This test has been failing as far as its history extends. It hasn't been touched since it was introduced at
188662@main
.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-03-21 20:27:35 PDT
<
rdar://problem/125210995
>
EWS
Comment 2
2024-03-21 20:38:11 PDT
Test gardening commit
276523@main
(5032256fcd90): <
https://commits.webkit.org/276523@main
> Reviewed commits have been landed. Closing PR #26294 and removing active labels.
Abrar Rahman Protyasha
Comment 3
2024-03-21 21:37:47 PDT
The expected dimensions match that of the iPhone SE (Gen 1) while the actual dimensions match that of the iPhone 12. This checks out because we used to run layout tests with the iPhone SE Gen 1 simulator, and have been running layout tests with the iPhone 12 simulator by default since
256495@main
. This test just needs a rebaseline because the device type has changed.
Abrar Rahman Protyasha
Comment 4
2024-03-22 00:48:00 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/26303
EWS
Comment 5
2024-03-23 06:55:16 PDT
Committed
276589@main
(fec218f3209a): <
https://commits.webkit.org/276589@main
> Reviewed commits have been landed. Closing PR #26303 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug