WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
271431
[webkitscmpy] Fix commits(..., include_identifier=False)
https://bugs.webkit.org/show_bug.cgi?id=271431
Summary
[webkitscmpy] Fix commits(..., include_identifier=False)
Jonathan Bedard
Reported
2024-03-21 17:24:08 PDT
The 'commits' function attempts to make assumptions to reduce the number of `git` calls we make. Some of those assumptions rely on identifiers being set, so using include_identifiers=False ends up with an exception. We should fix this.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-03-21 17:24:37 PDT
<
rdar://problem/125203035
>
Jonathan Bedard
Comment 2
2024-03-21 17:26:37 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/26283
EWS
Comment 3
2024-03-22 09:15:54 PDT
Committed
276551@main
(4666c5a78b42): <
https://commits.webkit.org/276551@main
> Reviewed commits have been landed. Closing PR #26283 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug