Bug 271408 – fast/images/decode-render-animated-image.html is flaky image failure

• Status: RESOLVED
• Resolution: FIXED
• Component: Images

[Fujii Hironori]

fast/images/decode-render-animated-image.html is randomly failing an assertion.

History:
  https://results.webkit.org/?suite=layout-tests&test=fast%2Fimages%2Fdecode-render-animated-image.html

Buildbot: builder Apple-Monterey-Debug-WK2-Tests build 9762 : 273820@main
https://build.webkit.org/#/builders/369/builds/9762

https://build.webkit.org/results/Apple-Monterey-Debug-WK2-Tests/273820@main%20(9762)/fast/images/decode-render-animated-image-stderr.txt

ASSERTION FAILED: status == StartAnimationStatus::DecodingActive => (!m_currentFrame && !m_repetitionsComplete) || frameHasFullSizeNativeImageAtIndex(m_currentFrame, m_currentSubsamplingLevel)
platform/graphics/BitmapImage.cpp(243) : virtual WebCore::ImageDrawResult WebCore::BitmapImage::draw(WebCore::GraphicsContext &, const WebCore::FloatRect &, const WebCore::FloatRect &, WebCore::ImagePaintingOptions)
1   0x67396b689 WTFCrash
2   0x72a580064 WebCore::BitmapImage::draw(WebCore::GraphicsContext&, WebCore::FloatRect const&, WebCore::FloatRect const&, WebCore::ImagePaintingOptions)
3   0x72a6b1fd0 WebCore::GraphicsContext::drawImage(WebCore::Image&, WebCore::FloatRect const&, WebCore::FloatRect const&, WebCore::ImagePaintingOptions)
4   0x72a6b1f26 WebCore::GraphicsContext::drawImage(WebCore::Image&, WebCore::FloatRect const&, WebCore::ImagePaintingOptions)
5   0x72b0d4792 WebCore::RenderImage::paintIntoRect(WebCore::PaintInfo&, WebCore::FloatRect const&)
6   0x72b0d3dda WebCore::RenderImage::paintReplaced(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
7   0x72b1d0d0a WebCore::RenderReplaced::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
8   0x72b0d4869 WebCore::RenderImage::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
9   0x72b05ae0c WebCore::paintPhase(WebCore::RenderElement&, WebCore::PaintPhase, WebCore::PaintInfo&, WebCore::LayoutPoint const&)
10  0x72b05ad95 WebCore::RenderElement::paintAsInlineBlock(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
11  0x729d16774 WebCore::LayoutIntegration::InlineContentPainter::paintDisplayBox(WebCore::InlineDisplay::Box const&)
12  0x729d16b5b WebCore::LayoutIntegration::InlineContentPainter::paint()
13  0x729d1df5c WebCore::LayoutIntegration::LineLayout::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::RenderInline const*)
14  0x72afcb8a8 WebCore::RenderBlockFlow::paintInlineChildren(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
15  0x72af9e44a WebCore::RenderBlock::paintContents(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
16  0x72af9f79b WebCore::RenderBlock::paintObject(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
17  0x72af9ddbf WebCore::RenderBlock::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
18  0x72af9e9f0 WebCore::RenderBlock::paintChild(WebCore::RenderBox&, WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::PaintInfo&, bool, WebCore::RenderBlock::PaintBlockType)
19  0x72af9e628 WebCore::RenderBlock::paintChildren(WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::PaintInfo&, bool)
20  0x72af9e573 WebCore::RenderBlock::paintContents(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
21  0x72af9f79b WebCore::RenderBlock::paintObject(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
22  0x72af9ddbf WebCore::RenderBlock::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
23  0x72af9e9f0 WebCore::RenderBlock::paintChild(WebCore::RenderBox&, WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::PaintInfo&, bool, WebCore::RenderBlock::PaintBlockType)
24  0x72af9e628 WebCore::RenderBlock::paintChildren(WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::PaintInfo&, bool)
25  0x72af9e573 WebCore::RenderBlock::paintContents(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
26  0x72af9f79b WebCore::RenderBlock::paintObject(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
27  0x72af9ddbf WebCore::RenderBlock::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
28  0x72b0f4258 WebCore::RenderLayer::paintForegroundForFragmentsWithPhase(WebCore::PaintPhase, WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*)
29  0x72b0f1e90 WebCore::RenderLayer::paintForegroundForFragments(WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::GraphicsContext&, WebCore::GraphicsContext&, WebCore::LayoutRect const&, bool, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*)
30  0x72b0ed7ba WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>)
31  0x72b0ec8ec WebCore::RenderLayer::paintLayerContentsAndReflection(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>)
com.apple.WebKit.WebContent.Development terminated (pid 59611) for reason: crash
LEAK: 1 WebPageProxy

[Fujii Hironori]

Buildbot: builder WPE-Linux-64-bit-Debug-Tests build 8055 : 273604@main
https://build.webkit.org/#/builders/14/builds/8055

https://build.webkit.org/results/WPE-Linux-64-bit-Debug-Tests/273604@main%20(8055)/fast/images/decode-render-animated-image-crash-log.txt

STDERR: ASSERTION FAILED: status == StartAnimationStatus::DecodingActive => (!m_currentFrame && !m_repetitionsComplete) || frameHasFullSizeNativeImageAtIndex(m_currentFrame, m_currentSubsamplingLevel)
STDERR: /app/webkit/Source/WebCore/platform/graphics/BitmapImage.cpp(273) : virtual WebCore::ImageDrawResult WebCore::BitmapImage::draw(WebCore::GraphicsContext&, const WebCore::FloatRect&, const WebCore::FloatRect&, WebCore::ImagePaintingOptions)
STDERR: 1   0x7fa973c729c9 WTFCrash
STDERR: 2   0x7fa9783755e3 WebCore::BitmapImage::draw(WebCore::GraphicsContext&, WebCore::FloatRect const&, WebCore::FloatRect const&, WebCore::ImagePaintingOptions)
STDERR: 3   0x7fa97847892b WebCore::GraphicsContext::drawImage(WebCore::Image&, WebCore::FloatRect const&, WebCore::FloatRect const&, WebCore::ImagePaintingOptions)
STDERR: 4   0x7fa97847887f WebCore::GraphicsContext::drawImage(WebCore::Image&, WebCore::FloatRect const&, WebCore::ImagePaintingOptions)
STDERR: 5   0x7fa978bc753a WebCore::RenderImage::paintIntoRect(WebCore::PaintInfo&, WebCore::FloatRect const&)
STDERR: 6   0x7fa978bc6a8a WebCore::RenderImage::paintReplaced(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
STDERR: 7   0x7fa978ca8c95 WebCore::RenderReplaced::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
STDERR: 8   0x7fa978bc6c7b WebCore::RenderImage::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
STDERR: 9   0x7fa978b56706 paintPhase
STDERR: 10  0x7fa978b56819 WebCore::RenderElement::paintAsInlineBlock(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
STDERR: 11  0x7fa977ca4341 WebCore::LayoutIntegration::InlineContentPainter::paintDisplayBox(WebCore::InlineDisplay::Box const&)
STDERR: 12  0x7fa977ca45b8 WebCore::LayoutIntegration::InlineContentPainter::paint()
STDERR: 13  0x7fa977cb0e26 WebCore::LayoutIntegration::LineLayout::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::RenderInline const*)
STDERR: 14  0x7fa978ac939a WebCore::RenderBlockFlow::paintInlineChildren(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
STDERR: 15  0x7fa978aa7499 WebCore::RenderBlock::paintContents(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
STDERR: 16  0x7fa978aa864f WebCore::RenderBlock::paintObject(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
STDERR: 17  0x7fa978aa72ce WebCore::RenderBlock::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
STDERR: 18  0x7fa978aa79f3 WebCore::RenderBlock::paintChild(WebCore::RenderBox&, WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::PaintInfo&, bool, WebCore::RenderBlock::PaintBlockType)
STDERR: 19  0x7fa978aa766f WebCore::RenderBlock::paintChildren(WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::PaintInfo&, bool)
STDERR: 20  0x7fa978aa75f4 WebCore::RenderBlock::paintContents(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
STDERR: 21  0x7fa978aa864f WebCore::RenderBlock::paintObject(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
STDERR: 22  0x7fa978aa72ce WebCore::RenderBlock::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
STDERR: 23  0x7fa978aa79f3 WebCore::RenderBlock::paintChild(WebCore::RenderBox&, WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::PaintInfo&, bool, WebCore::RenderBlock::PaintBlockType)
STDERR: 24  0x7fa978aa766f WebCore::RenderBlock::paintChildren(WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::PaintInfo&, bool)
STDERR: 25  0x7fa978aa75f4 WebCore::RenderBlock::paintContents(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
STDERR: 26  0x7fa978aa864f WebCore::RenderBlock::paintObject(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
STDERR: 27  0x7fa978aa72ce WebCore::RenderBlock::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
STDERR: 28  0x7fa978bdfda6 WebCore::RenderLayer::paintForegroundForFragmentsWithPhase(WebCore::PaintPhase, WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*)
STDERR: 29  0x7fa978bdfa94 WebCore::RenderLayer::paintForegroundForFragments(WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::GraphicsContext&, WebCore::GraphicsContext&, WebCore::LayoutRect const&, bool, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*)
STDERR: 30  0x7fa978bdd6c3 WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>)
STDERR: 31  0x7fa978bdb0f6 WebCore::RenderLayer::paintLayerContentsAndReflection(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>)
STDERR: WPEWebProcess terminated (pid 86438) for reason: crash

[Radar WebKit Bug Importer]

<rdar://problem/125573776>

[Said Abou-Hallawa]

Before 276827@main, the assertion was failing sometimes. The above assertion was deleted in 276827@main. Now sometimes an ImageFailure may happen when running this test.

[Said Abou-Hallawa]

Pull request: https://github.com/WebKit/WebKit/pull/28868

[EWS]

Test gardening commit 279153@main (d61c828315d6): <https://commits.webkit.org/279153@main>

Reviewed commits have been landed. Closing PR #28868 and removing active labels.

[Said Abou-Hallawa]

I will remove the test from the expectations once I can confirm the flakiness is fixed. This might take one day or two.

[Said Abou-Hallawa]

Pull request: https://github.com/WebKit/WebKit/pull/29176

[EWS]

Test gardening commit 279396@main (0cbfcb62088b): <https://commits.webkit.org/279396@main>

Reviewed commits have been landed. Closing PR #29176 and removing active labels.