Bug 271396 - [Skia] Create the font manager on demand when first needed
Summary: [Skia] Create the font manager on demand when first needed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Garcia Campos
URL:
Keywords: InRadar
Depends on:
Blocks: GLibSkia
  Show dependency tree / graph
 
Reported: 2024-03-21 10:25 PDT by Carlos Garcia Campos
Modified: 2024-03-21 12:02 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2024-03-21 10:25:09 PDT 
We are creating the font manager in FontCache::platformInit(), but that's only called once for all the instances. This makes all offscreen canvas tests rendering text to crash, because the FontCache in the worker thread doesn't have a font manager.
Comment 1 Carlos Garcia Campos 2024-03-21 10:33:43 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/26252
Comment 2 EWS 2024-03-21 12:01:15 PDT 
Committed 276483@main (82bbfe731a36): <https://commits.webkit.org/276483@main>

Reviewed commits have been landed. Closing PR #26252 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2024-03-21 12:02:15 PDT 
<rdar://problem/125183297>