WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
27134
[V8] Make DOMWrapper interface more like JSC
https://bugs.webkit.org/show_bug.cgi?id=27134
Summary
[V8] Make DOMWrapper interface more like JSC
Adam Barth
Reported
2009-07-09 16:11:50 PDT
In JSC you make a wrapper by saying toJS. In V8, we have a bunch of different functions that do that. We should unify them. I've worked up a patch with the name V8DOMWrapper::wrap (soon to be followed with V8DOMWrapper::unwrap for the reverse operation). Patch forthcoming.
Attachments
Patch (renaming only)
(30.96 KB, patch)
2009-07-09 16:19 PDT
,
Adam Barth
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2009-07-09 16:19:53 PDT
Created
attachment 32537
[details]
Patch (renaming only)
Eric Seidel (no email)
Comment 2
2009-07-09 17:17:56 PDT
Comment on
attachment 32537
[details]
Patch (renaming only) Why not just call them toJS like the JSC bindings? And make them autogenerated like the JSC bindings? Or is that the eventual plan?
Adam Barth
Comment 3
2009-07-09 17:37:17 PDT
That sound rocking. Cancel the review and I'll do that instead.
Brian Burg
Comment 4
2014-12-16 00:48:07 PST
Closing some V8-related work items.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug