Bug 27134 - [V8] Make DOMWrapper interface more like JSC
Summary: [V8] Make DOMWrapper interface more like JSC
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-09 16:11 PDT by Adam Barth
Modified: 2014-12-16 00:48 PST (History)
3 users (show)

See Also:


Attachments
Patch (renaming only) (30.96 KB, patch)
2009-07-09 16:19 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-07-09 16:11:50 PDT
In JSC you make a wrapper by saying toJS.  In V8, we have a bunch of different functions that do that.  We should unify them.  I've worked up a patch with the name V8DOMWrapper::wrap (soon to be followed with V8DOMWrapper::unwrap for the reverse operation).

Patch forthcoming.
Comment 1 Adam Barth 2009-07-09 16:19:53 PDT
Created attachment 32537 [details]
Patch (renaming only)
Comment 2 Eric Seidel (no email) 2009-07-09 17:17:56 PDT
Comment on attachment 32537 [details]
Patch (renaming only)

Why not just call them toJS like the JSC bindings?  And make them autogenerated like the JSC bindings?

Or is that the eventual plan?
Comment 3 Adam Barth 2009-07-09 17:37:17 PDT
That sound rocking.  Cancel the review and I'll do that instead.
Comment 4 Brian Burg 2014-12-16 00:48:07 PST
Closing some V8-related work items.