Bug 271310 - Read from the cached `display: none` style in select call sites of `Element::renderOrDisplayContentsStyle()`
Summary: Read from the cached `display: none` style in select call sites of `Element::...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-20 05:04 PDT by Antoine Quint
Modified: 2024-03-20 11:14 PDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2024-03-20 05:04:29 PDT 
In 273288@main we started caching `display: none` styles in a similar fashion we do `display: contents` style. One of the way the cached `display: contents` style is used is through the `Element::renderOrDisplayContentsStyle()` method. We need to audit those call sites and also ready for the `display: none` style when appropriate.
Comment 1 Antoine Quint 2024-03-20 05:10:17 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/26186
Comment 2 Antoine Quint 2024-03-20 11:14:12 PDT 
After further consideration, I don't think this is a good thing to do and we should reduce the scope of where we return the displayContentsOrNoneStyle() value.