WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
271276
check-for-duplicated-platform-test-results fails to simplify ipad & wincairo
https://bugs.webkit.org/show_bug.cgi?id=271276
Summary
check-for-duplicated-platform-test-results fails to simplify ipad & wincairo
Sam Sneddon [:gsnedders]
Reported
2024-03-19 15:13:46 PDT
We simply never manage to initialise a Port object for ipad:
> Failed to create port object for ipad
And fail to find baseline search path for wincairo:
> Error computing baseline search paths from wincairo, 'NoneType' object has no attribute 'lower'
We probably need to both fix wincairo for when it doesn't know about an OS version and to only use the host OS version when running on Windows. This should also improve our ability to find baseline search paths for other ports in general.
Attachments
Add attachment
proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1
2024-03-19 15:41:10 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/26153
EWS
Comment 2
2024-04-22 16:15:45 PDT
Committed
277843@main
(b8532bcbdb39): <
https://commits.webkit.org/277843@main
> Reviewed commits have been landed. Closing PR #26153 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2024-04-22 16:16:16 PDT
<
rdar://problem/126887595
>
Jonathan Bedard
Comment 4
2024-04-23 08:21:13 PDT
Re-opening for pull request
https://github.com/WebKit/WebKit/pull/27630
EWS
Comment 5
2024-04-23 09:05:21 PDT
Committed
277872@main
(1a65f54c1c2c): <
https://commits.webkit.org/277872@main
> Reviewed commits have been landed. Closing PR #27630 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug