Bug 271262 - [webkitpy] Unify expectations_files and baseline_search_path
Summary: [webkitpy] Unify expectations_files and baseline_search_path
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Sneddon [:gsnedders]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-03-19 13:03 PDT by Sam Sneddon [:gsnedders]
Modified: 2024-03-26 13:04 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2024-03-19 13:03:38 PDT 
Currently we override Port._port_specific_expectations_files and define it based on the baseline search path in DarwinPort, WinPort, GtkPort, and WPEPort.

This means the only places where we have TestExpectations having a separate search path to baselines are: JscOnlyPort, TestPort, and TestWebKitPort.

We shouldn't have totally different behaviour in TestPort and TestWebKitPort to the rest of the world, so we should just define Port._port_specific_expectations_files in terms of Port. baseline_search_path.
Comment 1 Sam Sneddon [:gsnedders] 2024-03-19 13:19:41 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/26140
Comment 2 Radar WebKit Bug Importer 2024-03-26 13:04:14 PDT 
<rdar://problem/125435314>