Bug 27122 - prepare-ChangeLog should decode HTML entities in short description
Summary: prepare-ChangeLog should decode HTML entities in short description
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-09 10:25 PDT by Shinichiro Hamaji
Modified: 2009-07-13 02:37 PDT (History)
2 users (show)

See Also:

Attachments
Patch v1 (1.45 KB, patch)
2009-07-09 10:27 PDT, Shinichiro Hamaji 		no flags Details | Formatted Diff | Diff
Patch v2 (1.80 KB, patch)
2009-07-09 12:47 PDT, Shinichiro Hamaji 		no flags Details | Formatted Diff | Diff
Patch v3 (2.04 KB, patch)
2009-07-09 13:03 PDT, Shinichiro Hamaji 		mjs: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shinichiro Hamaji 2009-07-09 10:25:01 PDT 
When I ran

./WebKitTools/Scripts/prepare-ChangeLog --bug=25406

I've got

-webkit-box-orient:horizontal doesn't work on <button> tag

in ChangeLog. It is better to decode HTML entities.
Comment 1 Shinichiro Hamaji 2009-07-09 10:27:04 PDT 
Created attachment 32522 [details]
Patch v1
Comment 2 Darin Adler 2009-07-09 12:07:54 PDT 
Comment on attachment 32522 [details]
Patch v1

Is the HTML::Entities package installed on everyone's system? Is it included with Mac OS X, for example?
Comment 3 Shinichiro Hamaji 2009-07-09 12:26:43 PDT 
(In reply to comment #2)
> (From update of attachment 32522 [details])
> Is the HTML::Entities package installed on everyone's system? Is it included
> with Mac OS X, for example?

Environments I checked (OSX 10.4, 10.5, Debian, Ubuntu, Cygwin) had the module. However, I've just noticed that perl-5.8.8 source package don't have the module so it seems not to be a part of standard. Should I implement it by myself? It would not difficult at all because we don't need all HTML entites but ones bugzilla use (maybe <>"'& I guess?).
Comment 4 Shinichiro Hamaji 2009-07-09 12:47:43 PDT 
Created attachment 32527 [details]
Patch v2
Comment 5 Shinichiro Hamaji 2009-07-09 12:53:03 PDT 
Attached another patch which doesn't use HTML::Entities. I grepped bugzilla's source code and found xml_quote is the only function which has "&apos;". So, I guessed that we don't need to decode &#[0-9a-f]{3}; style entities.
Comment 6 Shinichiro Hamaji 2009-07-09 13:03:27 PDT 
Created attachment 32528 [details]
Patch v3

Oops sorry. I forgot to add function declaration for decodeEntities.
Comment 7 Maciej Stachowiak 2009-07-09 20:07:28 PDT 
Comment on attachment 32528 [details]
Patch v3

r=me
Comment 8 David Levin 2009-07-13 02:37:39 PDT 
Committed as http://trac.webkit.org/changeset/45799