Bug 271199 – AX: Move Mac test-only APIs out of [WebAccessibilityObjectWrapper accessibilityAttributeValue:].

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Andres Gonzalez]

.

[Radar WebKit Bug Importer]

<rdar://problem/124976011>

[Andres Gonzalez]

Created attachment 470426 [details]
Patch

[Andres Gonzalez]

Created attachment 470431 [details]
Patch

[chris fleizach]

Comment on attachment 470431 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=470431&action=review

> Source/WebCore/accessibility/AXObjectCache.h:530
> +    static bool isTestClient();

isTestClient() is a bit weird of a name for AXObjectCache, since the AXObjectCache isn't the test client. 

clientIsInTestMode()

is a bit more accurate

[Andres Gonzalez]

Created attachment 470449 [details]
Patch

[Andres Gonzalez]

(In reply to chris fleizach from comment #4)
> Comment on attachment 470431 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=470431&action=review
> 
> > Source/WebCore/accessibility/AXObjectCache.h:530
> > +    static bool isTestClient();
> 
> isTestClient() is a bit weird of a name for AXObjectCache, since the
> AXObjectCache isn't the test client. 
> 
> clientIsInTestMode()
> 
> is a bit more accurate

Done.

[Andres Gonzalez]

Created attachment 470462 [details]
Patch

[EWS]

Committed 276515@main (8725aa98a991): <https://commits.webkit.org/276515@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 470462 [details].