Bug 271168 – AX: The accname for summary elements should use on subtree text over the title attribute

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Tyler Wilcock]

...

[Radar WebKit Bug Importer]

<rdar://problem/124958776>

[Tyler Wilcock]

Created attachment 470419 [details]
Patch

[chris fleizach]

No test that verified this behavior?

[Tyler Wilcock]

(In reply to chris fleizach from comment #3)
> No test that verified this behavior?
We pass one additional WPT sub-test (note the change of FAIL to PASS in the test expectation file updates).

[Andres Gonzalez]

(In reply to Tyler Wilcock from comment #2)
> Created attachment 470419 [details]
> Patch

--- a/LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_tooltip-expected.txt
+++ b/LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_tooltip-expected.txt
@@ -28,6 +28,6 @@ PASS url input with placeholder and tooltip label
 PASS textarea with placeholder and tooltip label
 PASS abbr with tooltip label
 PASS kbd with tooltip label
-FAIL summary with tooltip label and contents assert_equals: <summary title="title" data-expectedlabel="contents" data-testname="summary with tooltip label and contents" class="ex">contents</summary> expected "contents" but got "title"
+PASS summary with tooltip label and contents

AG: this seems contrary to the "rule" that the ARIA attributes override the HTML construct. If the title is ignored, why to allow a title for this element in the first place? I think your change is fine to pass the test, what I'm questioning is the test itself.

[chris fleizach]

(In reply to Tyler Wilcock from comment #4)
> (In reply to chris fleizach from comment #3)
> > No test that verified this behavior?
> We pass one additional WPT sub-test (note the change of FAIL to PASS in the
> test expectation file updates).

But we removed a very specific behavior. No test was checking that presumably?

[Tyler Wilcock]

(In reply to chris fleizach from comment #6)
> (In reply to Tyler Wilcock from comment #4)
> > (In reply to chris fleizach from comment #3)
> > > No test that verified this behavior?
> > We pass one additional WPT sub-test (note the change of FAIL to PASS in the
> > test expectation file updates).
> 
> But we removed a very specific behavior. No test was checking that
> presumably?
Ah, yes sorry I misunderstood. This behavior was added in:

https://github.com/WebKit/WebKit/commit/ef43e42c5970c6e8ee6423edf077d79829b00867

With no test. It's also contrary to the spec, and to what the other two browsers do, so seems right to remove.

[Tyler Wilcock]

(In reply to Andres Gonzalez from comment #5)
> (In reply to Tyler Wilcock from comment #2)
> > Created attachment 470419 [details]
> > Patch
> 
> ---
> a/LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_tooltip-
> expected.txt
> +++
> b/LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_tooltip-
> expected.txt
> @@ -28,6 +28,6 @@ PASS url input with placeholder and tooltip label
>  PASS textarea with placeholder and tooltip label
>  PASS abbr with tooltip label
>  PASS kbd with tooltip label
> -FAIL summary with tooltip label and contents assert_equals: <summary
> title="title" data-expectedlabel="contents" data-testname="summary with
> tooltip label and contents" class="ex">contents</summary> expected
> "contents" but got "title"
> +PASS summary with tooltip label and contents
> 
> AG: this seems contrary to the "rule" that the ARIA attributes override the
> HTML construct. If the title is ignored, why to allow a title for this
> element in the first place? I think your change is fine to pass the test,
> what I'm questioning is the test itself.
TW: Seems like a good question to raise on the spec, or starting a discussion elsewhere. It's been like this since the html-aam spec was first written. I traced it back to 8 years ago (https://github.com/w3c/html-aam/blame/b9b93b9bd67deb5473c1da3be299705b870b4a80/index.html) hoping to find a reasoning for this, but didn't have any luck.

[EWS]

Committed 276323@main (652ad7d7e57a): <https://commits.webkit.org/276323@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 470419 [details].