Created attachment 32514 [details] Patch v1 Reviewed by NOBODY (OOPS!). * Scripts/bugzilla-tool: Removed error() and log() methods and added import of new logging module. * Scripts/modules/bugzilla.py: Ditto. Removed "import sys". * Scripts/modules/scm.py: Ditto. * Scripts/modules/logging.py: Added. (log): Added. (error): Added. Prefix error messages with "ERROR: ". --- 5 files changed, 60 insertions(+), 22 deletions(-)
Comment on attachment 32514 [details] Patch v1 I'm no Python expert, but this seems reasonable, and I'm sure you followed the example of the existing code. r=me
Looks good.
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool M WebKitTools/Scripts/modules/bugzilla.py A WebKitTools/Scripts/modules/logging.py M WebKitTools/Scripts/modules/scm.py Committed r45725 M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/bugzilla.py M WebKitTools/Scripts/modules/scm.py A WebKitTools/Scripts/modules/logging.py M WebKitTools/Scripts/bugzilla-tool r45725 = 6c272cc56dee4c1ae1c0dd23491efb1b1b86adbd (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/45725