Bug 27115 - bugzilla-tool: extract duplicate logging methods into a module
Summary: bugzilla-tool: extract duplicate logging methods into a module
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-07-09 05:50 PDT by David Kilzer (:ddkilzer)
Modified: 2009-07-10 14:02 PDT (History)
1 user (show)

See Also:

Patch v1 (4.85 KB, patch)
2009-07-09 05:50 PDT, David Kilzer (:ddkilzer)
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2009-07-09 05:50:57 PDT
Created attachment 32514 [details]
Patch v1

Reviewed by NOBODY (OOPS!).

* Scripts/bugzilla-tool: Removed error() and log() methods and
added import of new logging module.
* Scripts/modules/bugzilla.py: Ditto.  Removed "import sys".
* Scripts/modules/scm.py: Ditto.

* Scripts/modules/logging.py: Added.
(log): Added.
(error): Added.  Prefix error messages with "ERROR: ".
 5 files changed, 60 insertions(+), 22 deletions(-)
Comment 1 Adam Roben (:aroben) 2009-07-09 09:32:59 PDT
Comment on attachment 32514 [details]
Patch v1

I'm no Python expert, but this seems reasonable, and I'm sure you followed the example of the existing code.

Comment 2 Eric Seidel (no email) 2009-07-09 14:39:49 PDT
Looks good.
Comment 3 David Kilzer (:ddkilzer) 2009-07-10 14:02:27 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/bugzilla-tool
	M	WebKitTools/Scripts/modules/bugzilla.py
	A	WebKitTools/Scripts/modules/logging.py
	M	WebKitTools/Scripts/modules/scm.py
Committed r45725
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/modules/bugzilla.py
	M	WebKitTools/Scripts/modules/scm.py
	A	WebKitTools/Scripts/modules/logging.py
	M	WebKitTools/Scripts/bugzilla-tool
r45725 = 6c272cc56dee4c1ae1c0dd23491efb1b1b86adbd (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk