RESOLVED FIXED271118
Drop Vector::append(T*, size_t) and use Vector::append(std::span<const T>) instead 
https://bugs.webkit.org/show_bug.cgi?id=271118
Summary Drop Vector::append(T*, size_t) and use Vector::append(std::span<const T>) in...
Chris Dumez
Reported 2024-03-16 23:35:09 PDT
Drop Vector::append(T*, size_t) and use Vector::append(std::span<const T>) instead. This is part of an effort to use std::span more in the codebase, for better security.
Attachments
Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2024-03-16 23:37:13 PDT
Pull request: https://github.com/WebKit/WebKit/pull/26014
EWS
Comment 2 2024-03-18 19:08:59 PDT
Committed 276319@main (c904754b70e1): <https://commits.webkit.org/276319@main> Reviewed commits have been landed. Closing PR #26014 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2024-03-18 19:09:13 PDT
<rdar://problem/124982635>
Diego Pino
Comment 4 2024-03-19 00:17:18 PDT
Build error in GTK-Linux-64-bit-Release-Debian-11-Build: https://build.webkit.org/#/builders/992/builds/750 ``` ../../../Source/WebCore/Modules/indexeddb/server/IDBSerialization.cpp:356:36: error: ‘auto’ parameter not permitted in this context 356 | Vector<uint8_t> dataVector(std::span { data, size }); | ```
Diego Pino
Comment 5 2024-03-19 00:20:59 PDT
Re-opening for pull request https://github.com/webkit/webkit/pull/26107
EWS
Comment 6 2024-03-19 00:31:31 PDT
Committed 276336@main (20ecbb6bc4e7): <https://commits.webkit.org/276336@main> Reviewed commits have been landed. Closing PR #26107 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.