Bug 271083 - [css-grid] Grid track sizing algorithm logical height computation unnecessarily dirties grid items
Summary: [css-grid] Grid track sizing algorithm logical height computation unnecessari...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sammy Gill
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-03-15 15:00 PDT by Sammy Gill
Modified: 2024-03-25 10:58 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sammy Gill 2024-03-15 15:00:36 PDT 
In certain conditions, the grid item logical height computation in the grid track sizing algorithm will modify the overriding containing block size for the grid items's block direction and mark the grid item dirty for layout. This dirtying occurs even if the override size remains the same. This can result in bad performance in certain pieces of content (e.g. nested grids)
Comment 1 Radar WebKit Bug Importer 2024-03-15 15:00:50 PDT 
<rdar://problem/124713418>
Comment 2 Sammy Gill 2024-03-15 15:36:00 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/25982
Comment 3 EWS 2024-03-25 10:58:19 PDT 
Committed 276633@main (ba849a630cec): <https://commits.webkit.org/276633@main>

Reviewed commits have been landed. Closing PR #25982 and removing active labels.