RESOLVED FIXED Bug 27107
[V8] Move DOM wrapper functions in V8Proxy to V8DOMWrapper 
https://bugs.webkit.org/show_bug.cgi?id=27107
Summary [V8] Move DOM wrapper functions in V8Proxy to V8DOMWrapper
Adam Barth
Reported 2009-07-08 19:03:40 PDT
Phase 1, do the renaming. Patch forthcoming.
Attachments
patch (renaming only) (229.61 KB, patch)
2009-07-08 23:12 PDT, Adam Barth 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2009-07-08 19:09:06 PDT
There's already V8DOMMap. Perhaps they belong there?
Adam Barth
Comment 2 2009-07-08 21:45:52 PDT
I think its better to have them in a separate class / file. I want to eventually make the API more like toJS() to match JSC. V8DOMMap is more of an implementation detail / backing store. For example, if we switched to a peerable-like implemenation, then we'd keep V8DOMWrappers but get rid of V8DOMMap (because there wouldn't be a "map" per se).
Adam Barth
Comment 3 2009-07-08 23:12:15 PDT
Created attachment 32503 [details] patch (renaming only) Sorry. The patch is huge. It's just renaming functions.
Eric Seidel (no email)
Comment 4 2009-07-08 23:22:47 PDT
Comment on attachment 32503 [details] patch (renaming only) rs=me
Adam Barth
Comment 5 2009-07-09 01:09:35 PDT
Transmitting file data ........................................................................ Committed revision 45659.
Note You need to log in before you can comment on or make changes to this bug.