Bug 27107 - [V8] Move DOM wrapper functions in V8Proxy to V8DOMWrapper
Summary: [V8] Move DOM wrapper functions in V8Proxy to V8DOMWrapper
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-08 19:03 PDT by Adam Barth
Modified: 2009-07-09 01:09 PDT (History)
2 users (show)

See Also:


Attachments
patch (renaming only) (229.61 KB, patch)
2009-07-08 23:12 PDT, Adam Barth
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-07-08 19:03:40 PDT
Phase 1, do the renaming.  Patch forthcoming.
Comment 1 Dimitri Glazkov (Google) 2009-07-08 19:09:06 PDT
There's already V8DOMMap. Perhaps they belong there?
Comment 2 Adam Barth 2009-07-08 21:45:52 PDT
I think its better to have them in a separate class / file.  I want to eventually make the API more like toJS() to match JSC.

V8DOMMap is more of an implementation detail / backing store.  For example, if we switched to a peerable-like implemenation, then we'd keep V8DOMWrappers but get rid of V8DOMMap (because there wouldn't be a "map" per se).
Comment 3 Adam Barth 2009-07-08 23:12:15 PDT
Created attachment 32503 [details]
patch (renaming only)

Sorry.  The patch is huge.  It's just renaming functions.
Comment 4 Eric Seidel (no email) 2009-07-08 23:22:47 PDT
Comment on attachment 32503 [details]
patch (renaming only)

rs=me
Comment 5 Adam Barth 2009-07-09 01:09:35 PDT
Transmitting file data ........................................................................
Committed revision 45659.