Bug 27103 - Upstream V8NPObject.h and V8NPObject.cpp
Summary: Upstream V8NPObject.h and V8NPObject.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-08 16:56 PDT by Albert J. Wong
Modified: 2009-07-14 16:31 PDT (History)
4 users (show)

See Also:


Attachments
Patch with V8NPObject.h, V8NPObject.cpp, plus fixes to other files that reference the old filename/function names. (22.40 KB, patch)
2009-07-08 17:03 PDT, Albert J. Wong
dglazkov: review-
Details | Formatted Diff | Diff
Address Dimitiri's comments. Also update with latest changes downstream due to V8Proxy refactor (22.39 KB, patch)
2009-07-10 12:23 PDT, Albert J. Wong
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Albert J. Wong 2009-07-08 16:56:03 PDT
Upstreaming V8 files from the chromium tree.
Comment 1 Albert J. Wong 2009-07-08 17:03:54 PDT
Created attachment 32488 [details]
Patch with V8NPObject.h, V8NPObject.cpp, plus fixes to other files that reference the old filename/function names.
Comment 2 Dimitri Glazkov (Google) 2009-07-09 12:54:35 PDT
Comment on attachment 32488 [details]
Patch with V8NPObject.h, V8NPObject.cpp, plus fixes to other files that reference the old filename/function names.

Thanks for doing this! Just two minor style nits:

> +enum InvokeFunctionType {
> +    INVOKE_METHOD = 1,
> +    INVOKE_CONSTRUCT = 2,
> +    INVOKE_DEFAULT = 3
> +};

InvokeError, etc.

> +    return v8::Local<v8::Value>(); // Do not intercept the call.

return notHandledByInterceptor();
Comment 3 Albert J. Wong 2009-07-10 12:23:53 PDT
Created attachment 32571 [details]
Address Dimitiri's comments.  Also update with latest changes downstream due to V8Proxy refactor
Comment 4 Dimitri Glazkov (Google) 2009-07-10 13:29:38 PDT
Comment on attachment 32571 [details]
Address Dimitiri's comments.  Also update with latest changes downstream due to V8Proxy refactor

r=me
Comment 5 Nate Chapin 2009-07-14 15:36:11 PDT
Landed as r45876.
Comment 6 David Levin 2009-07-14 16:31:58 PDT
Resolving since it was committed.