RESOLVED FIXED 27103
Upstream V8NPObject.h and V8NPObject.cpp 
https://bugs.webkit.org/show_bug.cgi?id=27103
Summary Upstream V8NPObject.h and V8NPObject.cpp
Albert J. Wong
Reported 2009-07-08 16:56:03 PDT
Upstreaming V8 files from the chromium tree.
Attachments
Patch with V8NPObject.h, V8NPObject.cpp, plus fixes to other files that reference the old filename/function names. (22.40 KB, patch)
2009-07-08 17:03 PDT, Albert J. Wong 		dglazkov: review-
DetailsFormatted DiffDiff
Address Dimitiri's comments. Also update with latest changes downstream due to V8Proxy refactor (22.39 KB, patch)
2009-07-10 12:23 PDT, Albert J. Wong 		dglazkov: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Albert J. Wong
Comment 1 2009-07-08 17:03:54 PDT
Created attachment 32488 [details] Patch with V8NPObject.h, V8NPObject.cpp, plus fixes to other files that reference the old filename/function names.
Dimitri Glazkov (Google)
Comment 2 2009-07-09 12:54:35 PDT
Comment on attachment 32488 [details] Patch with V8NPObject.h, V8NPObject.cpp, plus fixes to other files that reference the old filename/function names. Thanks for doing this! Just two minor style nits: > +enum InvokeFunctionType { > + INVOKE_METHOD = 1, > + INVOKE_CONSTRUCT = 2, > + INVOKE_DEFAULT = 3 > +}; InvokeError, etc. > + return v8::Local<v8::Value>(); // Do not intercept the call. return notHandledByInterceptor();
Albert J. Wong
Comment 3 2009-07-10 12:23:53 PDT
Created attachment 32571 [details] Address Dimitiri's comments. Also update with latest changes downstream due to V8Proxy refactor
Dimitri Glazkov (Google)
Comment 4 2009-07-10 13:29:38 PDT
Comment on attachment 32571 [details] Address Dimitiri's comments. Also update with latest changes downstream due to V8Proxy refactor r=me
Nate Chapin
Comment 5 2009-07-14 15:36:11 PDT
Landed as r45876.
David Levin
Comment 6 2009-07-14 16:31:58 PDT
Resolving since it was committed.
Note You need to log in before you can comment on or make changes to this bug.