NEW 271014
[style-checker] Conflicting rules about include ordering -- mixing system/custom headers and including Softlink.h headers after all other headers 
https://bugs.webkit.org/show_bug.cgi?id=271014
Summary [style-checker] Conflicting rules about include ordering -- mixing system/cus...
Abrar Rahman Protyasha
Reported 2024-03-14 15:52:13 PDT
On this PR, I am getting a style-checker error that I'm not sure how to address. It looks like there is a conflict between two include ordering rules: 1. Bad include order. Mixing system and custom headers. [build/include_order] [4] 2. *SoftLink.h header should be included after all other headers. [build/include_order] [4] I settled for surfacing error (1) in the PR because (2) could actually have correctness issues, but at any rate, style-checker will always return this "bad include order" error if (a) I try to include all related Softlink.h headers after all other headers and (b) I have a mix of system and custom headers to include for softlinking.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-03-14 15:52:22 PDT
<rdar://problem/124643125>
Abrar Rahman Protyasha
Comment 2 2024-03-14 15:52:49 PDT
Forgot to link to the PR in the description: https://github.com/WebKit/WebKit/pull/25900
Note You need to log in before you can comment on or make changes to this bug.