prepare-ChangeLog's new text is seen by some as overly verbose and SHOUTY.
Created attachment 32480 [details] patch
Comment on attachment 32480 [details] patch r=me
I didn't solve every possible problem with prepare-ChangeLog, but I tried to make it a bit less shouty. If you don't provide the --bug argument, it includes text like this: --------- 2009-07-08 Maciej Stachowiak <mjs@apple.com> Reviewed by NOBODY (OOPS!). Need a short description and bug URL (OOPS!) * Scripts/prepare-ChangeLog: --------- If you do use --bug, it provides text like this: --------- 2009-07-08 Maciej Stachowiak <mjs@apple.com> Reviewed by NOBODY (OOPS!). Make prepare-ChangeLog less shouty https://bugs.webkit.org/show_bug.cgi?id=27098 * Scripts/prepare-ChangeLog: --------- It also says this on the console (not in the ChangeLog): -- Please remember to include a detailed description in your ChangeLog entry. -- -- See <http://webkit.org/coding/contributing.html> for more info --
Comment on attachment 32480 [details] patch + print CHANGE_LOG normalizeLineEndings(" $bugDescription\n", $endl) if $bugDescription; does not need to be conditional anymore. You can remove the "if ..." part. + print CHANGE_LOG normalizeLineEndings(" No new tests. (OOPS!)\n\n", $endl); Seems like that line will often be left in by casual contributers. Mabe just change it back to the WARNING: line before my change? Really, it's up to you.
At least when I was testing, the conditional was needed, otherwise it inserted extra blank lines. The "OOPS!" will prevent the "lack of tests" line from being committed as-is. If we also make post-diff complain about it, we should be golden.
Also: I committed this.