Bug 270979 – [WPE] Build broken when building with libdrm disabled

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Miguel Gomez]

This is the error:

Source/WebCore/platform/graphics/PlatformDisplay.cpp: In static member function 'static std::unique_ptr<WebCore::PlatformDisplay> WebCore::PlatformDisplay::createPlatformDisplay()':
Source/WebCore/platform/graphics/PlatformDisplay.cpp:166:13: error: 'GBMDevice' has not been declared
  166 |         if (GBMDevice::singleton().isInitialized()) {
      |             ^~~~~~~~~
Source/WebCore/platform/graphics/PlatformDisplay.cpp:167:32: error: 'GBMDevice' has not been declared
  167 |             if (auto* device = GBMDevice::singleton().device(GBMDevice::Type::Render))
      |                                ^~~~~~~~~
Source/WebCore/platform/graphics/PlatformDisplay.cpp:167:62: error: 'GBMDevice' has not been declared
  167 |             if (auto* device = GBMDevice::singleton().device(GBMDevice::Type::Render))
      |                                                              ^~~~~~~~~
Source/WebCore/platform/graphics/PlatformDisplay.cpp:168:24: error: 'PlatformDisplayGBM' has not been declared
  168 |                 return PlatformDisplayGBM::create(device);
      |                        ^~~~~~~~~~~~~~~~~~

GBMDevice is only compiled if USE_GBM, which is set to off when USE_LIBDRM is off. There's a probably an #if USE(GBM) missigng somewhere.

[Miguel Gomez]

Not sure it affects, but I'm also setting ENABLE_WPE_1_1_API to ON.

[Miguel Gomez]

Pull request: https://github.com/WebKit/WebKit/pull/26306

[EWS]

Committed 276537@main (f7de50f089b0): <https://commits.webkit.org/276537@main>

Reviewed commits have been landed. Closing PR #26306 and removing active labels.