Bug 270948 - Limit `::-webkit-media-controls` to `audio` and `video` in `mediaControls.css`
Summary: Limit `::-webkit-media-controls` to `audio` and `video` in `mediaControls.css`
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-03-13 17:39 PDT by Ahmad Saleem
Modified: 2024-05-29 20:31 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2024-03-13 17:39:25 PDT 
SSIA
Comment 1 Radar WebKit Bug Importer 2024-03-20 17:40:13 PDT 
<rdar://problem/125128093>
Comment 2 Ahmad Saleem 2024-05-29 08:17:22 PDT 
PR - https://github.com/WebKit/WebKit/pull/25861

> I was checking today to see - if we can remove but it seems Playstation port list this in their PlatformPlayStation.cmake and Adwaita.cmake. So I think meanwhile it would be good to land. I will ask them separately, if we can remove this.

@Fuji & @Don - any plan to deprecate use of `mediaControls.css` in near terms? So we can remove it instead of this PR (or repurpose this).
Comment 3 Fujii Hironori 2024-05-29 14:48:36 PDT 
PlayStation port is still using it. Please keep it. We will start a internal discussion how we will migrate.
Comment 4 Ahmad Saleem 2024-05-29 14:49:45 PDT 
(In reply to Fujii Hironori from comment #3)
> PlayStation port is still using it. Please keep it. We will start a internal
> discussion how we will migrate.

No worries - I will just land this potential optimisation (with slight benefit) - might not be much. :-)

We can open new bug to remove this later. :-)
Comment 5 EWS 2024-05-29 20:31:17 PDT 
Committed 279491@main (7250ca3fb789): <https://commits.webkit.org/279491@main>

Reviewed commits have been landed. Closing PR #25861 and removing active labels.