RESOLVED FIXED270944
Drop Vector constructor taking a raw pointer and a size
https://bugs.webkit.org/show_bug.cgi?id=270944
Summary Drop Vector constructor taking a raw pointer and a size
Chris Dumez
Reported 2024-03-13 16:47:02 PDT
Drop Vector constructor taking a raw pointer and a size and port call sites to the constructor taking a std::span instead. This is work towards more widespread std::span adoption in WebKit, which has security benefits.
Attachments
Chris Dumez
Comment 1 2024-03-13 16:50:46 PDT
EWS
Comment 2 2024-03-15 20:05:18 PDT
Committed 276220@main (7263d3ab5680): <https://commits.webkit.org/276220@main> Reviewed commits have been landed. Closing PR #25854 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2024-03-15 20:06:14 PDT
Diego Pino
Comment 4 2024-03-18 12:48:53 PDT
Several build bots (Debian 11, Ubuntu 22.04) are failing after this change: https://build.webkit.org/#/builders/992/builds/740 ``` ../../../Source/WebCore/PAL/pal/crypto/gcrypt/CryptoDigestGCrypt.cpp:91:28: error: ‘auto’ parameter not permitted in this context 91 | Vector<uint8_t> result(std::span { gcry_md_read(m_context->md, 0), digestLen }); | ^~~ ``` These bots feature GCC10.2 and GCC11.4 respectively. The original PR tackled several build errors reported by EWS JSC bots, but since JSC bots build with `--jsc-only` flag, likely many other changes were not addressed.
Note You need to log in before you can comment on or make changes to this bug.