Bug 270920 - [webkitcorepy] Exit AutoInstall.install when disabled
Summary: [webkitcorepy] Exit AutoInstall.install when disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-03-13 11:19 PDT by Jonathan Bedard
Modified: 2024-03-14 08:43 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2024-03-13 11:19:15 PDT 
We should early exit AutoInstall.install if the AutoInstaller is disabled. Callers of this function may be expecting side-effects, so we should also log a message when we encounter this situation.
Comment 1 Radar WebKit Bug Importer 2024-03-13 11:20:41 PDT 
<rdar://problem/124542328>
Comment 2 Jonathan Bedard 2024-03-13 11:27:40 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/25828
Comment 3 EWS 2024-03-13 16:32:30 PDT 
Committed 276051@main (f657af17ad3a): <https://commits.webkit.org/276051@main>

Reviewed commits have been landed. Closing PR #25828 and removing active labels.
Comment 4 EWS 2024-03-14 08:43:59 PDT 
Committed 272448.732@safari-7618-branch (88863e8f5c53): <https://commits.webkit.org/272448.732@safari-7618-branch>

Reviewed commits have been landed. Closing PR #1129 and removing active labels.