WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
27092
media controller shouldn't scale its text element when text only zoom is being used.
https://bugs.webkit.org/show_bug.cgi?id=27092
Summary
media controller shouldn't scale its text element when text only zoom is bein...
Pierre d'Herbemont
Reported
Wednesday, July 8, 2009 10:06:19 PM UTC
media controller shouldn't scale its text element when text only zoom is being used. <
rdar://problem/7037987
>
Attachments
Patch
(32.40 KB, patch)
2015-07-20 11:14 PDT
,
Dave Hyatt
no flags
Details
Formatted Diff
Diff
Patch
(19.52 KB, patch)
2015-07-20 11:19 PDT
,
Dave Hyatt
simon.fraser
: review+
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from ews102 for mac-mavericks
(1.25 MB, application/zip)
2015-07-20 12:07 PDT
,
Build Bot
no flags
Details
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Dave Hyatt
Comment 1
Monday, July 20, 2015 7:14:03 PM UTC
Created
attachment 257104
[details]
Patch
WebKit Commit Bot
Comment 2
Monday, July 20, 2015 7:16:08 PM UTC
Attachment 257104
[details]
did not pass style-queue: ERROR: Source/WebCore/css/StyleBuilderCustom.h:742: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/CSSComputedStyleDeclaration.cpp:3185: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/CSSParser.cpp:2361: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/css/CSSParser.cpp:2368: One space before end of line comments [whitespace/comments] [5] Total errors found: 4 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 3
Monday, July 20, 2015 7:19:39 PM UTC
Created
attachment 257106
[details]
Patch
Simon Fraser (smfr)
Comment 4
Monday, July 20, 2015 7:23:48 PM UTC
Comment on
attachment 257106
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=257106&action=review
> Source/WebCore/rendering/style/RenderStyle.h:1375 > + void setTextZoom(TextZoom v) { SET_VAR(rareInheritedData, m_textZoom, v); }
'v' could have a better name.
Build Bot
Comment 5
Monday, July 20, 2015 8:07:17 PM UTC
Comment on
attachment 257106
[details]
Patch
Attachment 257106
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.appspot.com/results/6549306244857856
New failing tests: fast/text/wbr-styled.html fast/text/textIteratorNilRenderer.html fast/text/unicode-variation-selector.html fast/text/trailing-white-space-2.html fast/text/wbr-pre.html fast/text/wbr-in-pre-crash.html fast/text/wbr.html fast/text/trailing-white-space.html fast/text/wide-zero-width-space.html fast/text/vertical-rl-rtl-linebreak.html
Build Bot
Comment 6
Monday, July 20, 2015 8:07:21 PM UTC
Created
attachment 257115
[details]
Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Dave Hyatt
Comment 7
Tuesday, July 21, 2015 7:45:10 PM UTC
Fixed in
r187110
.
Dave Hyatt
Comment 8
Tuesday, July 21, 2015 9:31:24 PM UTC
Before this gets backed out, I do not believe any of these WK1 failures are legit. The tests pass when run individually, and when you look at the failures they are colorspace differences and/or font rendering differences. I think the test harness for WK1 is buggy here.
Jon Lee
Comment 9
Thursday, July 23, 2015 7:28:17 PM UTC
Test failures were addressed in 187120.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug