Bug 27092 - media controller shouldn't scale its text element when text only zoom is being used.
Summary: media controller shouldn't scale its text element when text only zoom is bein...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2009-07-08 14:06 PDT by Pierre d'Herbemont
Modified: 2015-07-23 11:28 PDT (History)
5 users (show)

See Also:


Attachments
Patch (32.40 KB, patch)
2015-07-20 11:14 PDT, Dave Hyatt
no flags Details | Formatted Diff | Diff
Patch (19.52 KB, patch)
2015-07-20 11:19 PDT, Dave Hyatt
simon.fraser: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-mavericks (1.25 MB, application/zip)
2015-07-20 12:07 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre d'Herbemont 2009-07-08 14:06:19 PDT
media controller shouldn't scale its text element when text only zoom is being used.

<rdar://problem/7037987>
Comment 1 Dave Hyatt 2015-07-20 11:14:03 PDT
Created attachment 257104 [details]
Patch
Comment 2 WebKit Commit Bot 2015-07-20 11:16:08 PDT
Attachment 257104 [details] did not pass style-queue:


ERROR: Source/WebCore/css/StyleBuilderCustom.h:742:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/css/CSSComputedStyleDeclaration.cpp:3185:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/css/CSSParser.cpp:2361:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/css/CSSParser.cpp:2368:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 4 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2015-07-20 11:19:39 PDT
Created attachment 257106 [details]
Patch
Comment 4 Simon Fraser (smfr) 2015-07-20 11:23:48 PDT
Comment on attachment 257106 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257106&action=review

> Source/WebCore/rendering/style/RenderStyle.h:1375
> +    void setTextZoom(TextZoom v) { SET_VAR(rareInheritedData, m_textZoom, v); }

'v' could have a better name.
Comment 5 Build Bot 2015-07-20 12:07:17 PDT
Comment on attachment 257106 [details]
Patch

Attachment 257106 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6549306244857856

New failing tests:
fast/text/wbr-styled.html
fast/text/textIteratorNilRenderer.html
fast/text/unicode-variation-selector.html
fast/text/trailing-white-space-2.html
fast/text/wbr-pre.html
fast/text/wbr-in-pre-crash.html
fast/text/wbr.html
fast/text/trailing-white-space.html
fast/text/wide-zero-width-space.html
fast/text/vertical-rl-rtl-linebreak.html
Comment 6 Build Bot 2015-07-20 12:07:21 PDT
Created attachment 257115 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 7 Dave Hyatt 2015-07-21 11:45:10 PDT
Fixed in r187110.
Comment 8 Dave Hyatt 2015-07-21 13:31:24 PDT
Before this gets backed out, I do not believe any of these WK1 failures are legit. The tests pass when run individually, and when you look at the failures they are colorspace differences and/or font rendering differences.

I think the test harness for WK1 is buggy here.
Comment 9 Jon Lee 2015-07-23 11:28:17 PDT
Test failures were addressed in 187120.