Bug 27089 - Fix V8 idl codegen to use unique constant names
Summary: Fix V8 idl codegen to use unique constant names
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-08 12:43 PDT by Marc-Antoine Ruel
Modified: 2009-07-08 13:33 PDT (History)
1 user (show)

See Also:


Attachments
Fix to use a DerivedSource.cpp-like cpp merger for v8 bindings (2.47 KB, patch)
2009-07-08 12:45 PDT, Marc-Antoine Ruel
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marc-Antoine Ruel 2009-07-08 12:43:14 PDT
Embed the interface name in the global constant names so coagulating all the .cc files into one compile unit works with V8 bindings.
Comment 1 Marc-Antoine Ruel 2009-07-08 12:45:51 PDT
Created attachment 32466 [details]
Fix to use a DerivedSource.cpp-like cpp merger for v8 bindings
Comment 2 Adam Barth 2009-07-08 13:28:18 PDT
Comment on attachment 32466 [details]
Fix to use a DerivedSource.cpp-like cpp merger for v8 bindings

LGTM
Comment 3 Adam Barth 2009-07-08 13:33:22 PDT
Sending        WebCore/ChangeLog
Sending        WebCore/bindings/scripts/CodeGeneratorV8.pm
Transmitting file data ..
Committed revision 45632.