RESOLVED FIXED270883
[UnifiedPDF] WebCore::DataDetectorHighlight should be decoupled from the page 
https://bugs.webkit.org/show_bug.cgi?id=270883
Summary [UnifiedPDF] WebCore::DataDetectorHighlight should be decoupled from the page
Abrar Rahman Protyasha
Reported 2024-03-12 17:21:08 PDT
Currently, DataDetectorHighlight instances require a WebCore::Page object at construction time. This is inconvenient when trying to fit this data type into the UnifiedPDF Data Detection code paths. We should instead offload the work required from WebCore::Page to the DataDetectorHighlightClient virtual interface, which various overlay controllers can implement (and call into Page, if need be, for implementation support)
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-03-12 17:21:16 PDT
<rdar://problem/124490748>
Abrar Rahman Protyasha
Comment 2 2024-03-12 17:46:05 PDT
Pull request: https://github.com/WebKit/WebKit/pull/25799
EWS
Comment 3 2024-03-13 18:35:09 PDT
Committed 276060@main (c4304291691c): <https://commits.webkit.org/276060@main> Reviewed commits have been landed. Closing PR #25799 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.