WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
270865
Always use DDHighlightCreateWithRectsInVisibleRectWithStyleAndDirection in DDHighlight creation code
https://bugs.webkit.org/show_bug.cgi?id=270865
Summary
Always use DDHighlightCreateWithRectsInVisibleRectWithStyleAndDirection in DD...
Abrar Rahman Protyasha
Reported
2024-03-12 10:55:42 PDT
Currently, we call DDHighlightCreateWithRectsInVisibleRectWithStyleAndDirection conditional on HAVE(DD_HIGHLIGHT_CREATE_WITH_SCALE). This is not necessary because all calls to the DDHighlight creation method happen in macOS-only codepaths, and the method in question is available on all supported macOS configurations.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-03-12 10:56:13 PDT
<
rdar://problem/124465778
>
Abrar Rahman Protyasha
Comment 2
2024-03-12 12:09:00 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/25784
EWS
Comment 3
2024-03-12 15:15:48 PDT
Committed
276001@main
(0df9914623bb): <
https://commits.webkit.org/276001@main
> Reviewed commits have been landed. Closing PR #25784 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug