Bug 27084 - Add -[WebView _ isProcessingUserGesture]
Summary: Add -[WebView _ isProcessingUserGesture]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac (Intel) OS X 10.5
: P2 Normal
Assignee: Greg Bolsinga
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2009-07-08 10:56 PDT by Greg Bolsinga
Modified: 2009-07-08 14:28 PDT (History)
2 users (show)

See Also:


Attachments
patch to implement bug fix (2.99 KB, patch)
2009-07-08 11:05 PDT, Greg Bolsinga
no flags Details | Formatted Diff | Diff
updated to address Darin's comments (5.39 KB, patch)
2009-07-08 13:18 PDT, Greg Bolsinga
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Bolsinga 2009-07-08 10:56:50 PDT
Some platforms need to know if a WebView is in the midst of a user gesture or not.

<rdar://problem/7038294>
Comment 1 Greg Bolsinga 2009-07-08 11:05:50 PDT
Created attachment 32460 [details]
patch to implement bug fix
Comment 2 Darin Adler 2009-07-08 11:07:47 PDT
Comment on attachment 32460 [details]
patch to implement bug fix

The word "hint" here is very strange. Can we come up with a more sensible name for this?
Comment 3 Greg Bolsinga 2009-07-08 11:09:09 PDT
"hint" is what it is called in WebCore; that's why I used it!
Comment 4 Darin Adler 2009-07-08 11:59:06 PDT
(In reply to comment #3)
> "hint" is what it is called in WebCore; that's why I used it!

Of course. My point is that an internal name inside WebCore can easily be changed any time. As soon as we expose it as SPI or API it becomes much harder to change, so the bar is higher.

Maybe isProcessingUserGesture is a sensible alternative.
Comment 5 Greg Bolsinga 2009-07-08 11:59:36 PDT
Should I change it in WebCore as well? Thanks.
Comment 6 Darin Adler 2009-07-08 12:02:19 PDT
(In reply to comment #5)
> Should I change it in WebCore as well?

Sure, I think so.
Comment 7 Greg Bolsinga 2009-07-08 13:18:57 PDT
Created attachment 32468 [details]
updated to address Darin's comments
Comment 8 Greg Bolsinga 2009-07-08 14:28:26 PDT
-r45634 with an oddly super-long svn commit log.