Bug 270813 - Regression: Pages that update their title now get suspended when backgrounded
Summary: Regression: Pages that update their title now get suspended when backgrounded
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 271057
Blocks:
  Show dependency treegraph
 
Reported: 2024-03-11 13:13 PDT by Chris Dumez
Modified: 2024-03-20 14:09 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2024-03-11 13:13:50 PDT
Pages that update their title now get suspended when backgrounded since we've stopped taking near-suspended assertions on both iOS and macOS. We used to monitor pages in the background for 8 minutes to see if they update their title while in the background, if they did, we would let them keep running in the background.

Since we no longer take near-suspended assertions, we can no longer observe pages in the background (since they'd get suspended as soon as backgrounded). To address the issue, we now monitor title changes while in the foreground. If the page updates its title, we now take a background assertion to let it keep running after backgrounding.

This is not perfect but this addresses the regression for now. We should revisit though because this is too permissive.
Comment 1 Chris Dumez 2024-03-11 13:14:02 PDT
<rdar://124222280>
Comment 2 Chris Dumez 2024-03-11 13:18:09 PDT
Pull request: https://github.com/WebKit/WebKit/pull/25737
Comment 3 EWS 2024-03-11 23:16:36 PDT
Committed 275960@main (3130b409ab45): <https://commits.webkit.org/275960@main>

Reviewed commits have been landed. Closing PR #25737 and removing active labels.
Comment 4 WebKit Commit Bot 2024-03-15 08:05:10 PDT
Re-opened since this is blocked by bug 271057
Comment 5 Chris Dumez 2024-03-19 21:31:51 PDT
Pull request: https://github.com/WebKit/WebKit/pull/26170
Comment 6 EWS 2024-03-20 14:09:35 PDT
Committed 276418@main (7cd42ac1d51c): <https://commits.webkit.org/276418@main>

Reviewed commits have been landed. Closing PR #26170 and removing active labels.