Bug 27079 - sort-Xcode-project-file should sort case-insensitively, to match Xcode's files list
Summary: sort-Xcode-project-file should sort case-insensitively, to match Xcode's file...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-08 07:08 PDT by Adam Roben (:aroben)
Modified: 2009-07-10 12:19 PDT (History)
1 user (show)

See Also:


Attachments
Use case-insensitive comparisons when sorting Xcode project files (1.69 KB, patch)
2009-07-10 11:13 PDT, Adam Roben (:aroben)
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2009-07-08 07:08:49 PDT
Xcode's files list uses a case-insensitive sort. sort-Xcode-project-file should do the same so that the orders of the two lists match when a Group is selected in the Files & Groups pane.
Comment 1 Adam Roben (:aroben) 2009-07-10 11:13:10 PDT
Created attachment 32563 [details]
        Use case-insensitive comparisons when sorting Xcode project files


        This matches the sorting used in Xcode's files list.

        Fixes Bug 27079: sort-Xcode-project-file should sort
        case-insensitively, to match Xcode's files list
        <https://bugs.webkit.org/show_bug.cgi?id=27079>

        Reviewed by NOBODY (OOPS!).

        * Scripts/sort-Xcode-project-file:
        (sortChildrenByFileName):
        (sortFilesByFileName):
        Lowercase the strings before comparing them so that the comparison
        will be case-insensitive.
---
 2 files changed, 20 insertions(+), 2 deletions(-)
Comment 2 David Kilzer (:ddkilzer) 2009-07-10 11:18:23 PDT
Comment on attachment 32563 [details]
        Use case-insensitive comparisons when sorting Xcode project files

r=me!

Please run the script and commit the results after you're done (with no additional changes to the Xcode projects, please :).
Comment 3 Adam Roben (:aroben) 2009-07-10 12:18:50 PDT
Fixed in r45717
Comment 4 Adam Roben (:aroben) 2009-07-10 12:19:11 PDT
(In reply to comment #2)
> Please run the script and commit the results after you're done (with no
> additional changes to the Xcode projects, please :).

Done in r45719.